You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Require HTTPS for upstream panic-rule table checks - #653
The optional --upstream panic-rule table check followed redirects without restricting their protocol. This adds curl --proto '=https' and --proto-redir '=https' to that one fetch, addressing Sonar issue AaGsvalIi1OfbecDqiNE (shell:S6506).
The SHA-256 comparison, failure exit, canonical table/pin and default offline path remain unchanged. The command only reads the upstream table; it does not execute downloaded code.
Validation on signed head 222e364 (tree a480be96c3114bc764088bfd72d92a03d309be9d): Bash syntax, existing PA rule/table control, optional upstream comparison and git diff --check pass. ShellCheck was unavailable locally; hosted checks provide the separate CI result.
This is a one-file security correction based on c1d8754. The existing Rhodibot canon-lockstep mismatch and mirror setup/access failures remain separate. No canon repin, baseline waiver, credential or mirror change is included.
Merged as 46d26a4. Its verified signed tree exactly matches a480be96c3114bc764088bfd72d92a03d309be9d. All nine required PR contexts passed; CodeRabbit’s review check completed successfully with no inline findings. Post-merge main SonarCloud, E2E, pinned-source closure and Hypatia baseline pass. The open new-code vulnerability query is now empty. This does not resolve or waive the separate upstream canon-lockstep and mirror-configuration failures.
No actionable comments were generated in the recent review.
Walkthrough
The upstream table download now permits only HTTPS for the initial request and redirects. Existing timeout, failure handling, hash comparison, and re-pin error behavior remain unchanged.
The optional upstream check is restricted to HTTPS. No merge-blocking risk is evident from the supplied change context.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the HTTPS requirement for the upstream panic-rule table fetch.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between c1d8754 and 222e364.
Files selected for processing: 1
tests/panic-attack-rule-ids-test.sh
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional --upstream panic-rule table check followed redirects without restricting their protocol. This adds curl --proto '=https' and --proto-redir '=https' to that one fetch, addressing Sonar issue AaGsvalIi1OfbecDqiNE (shell:S6506).
The SHA-256 comparison, failure exit, canonical table/pin and default offline path remain unchanged. The command only reads the upstream table; it does not execute downloaded code.
Validation on signed head 222e364 (tree a480be96c3114bc764088bfd72d92a03d309be9d): Bash syntax, existing PA rule/table control, optional upstream comparison and git diff --check pass. ShellCheck was unavailable locally; hosted checks provide the separate CI result.
This is a one-file security correction based on c1d8754. The existing Rhodibot canon-lockstep mismatch and mirror setup/access failures remain separate. No canon repin, baseline waiver, credential or mirror change is included.
Merged as 46d26a4. Its verified signed tree exactly matches a480be96c3114bc764088bfd72d92a03d309be9d. All nine required PR contexts passed; CodeRabbit’s review check completed successfully with no inline findings. Post-merge main SonarCloud, E2E, pinned-source closure and Hypatia baseline pass. The open new-code vulnerability query is now empty. This does not resolve or waive the separate upstream canon-lockstep and mirror-configuration failures.