Skip to content

docs(proofs): mark the gap-analysis summary superseded; fix the README lib/ count - #1046

Merged
hyperpolymath merged 2 commits into
mainfrom
claude/gap-analysis-summary
Nov 10, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
claude/gap-analysis-summary

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

What

  • docs/proofs/gap-analysis.adoc: the TL;DR and inventory headings are dated "2026-04-22, superseded". The NOTE lists the 3 proof lanes that verify-proofs.yml gates today, each checked by proof-ledger.sh derive:

    • Idris2: every file in verification/proofs/idris2/, plus both ipkg packages.
    • Agda: LogtalkMigration.agda under the strict profile.
    • TLA+: TLC on KinGate.tla, as tested-only.

    It also says the remaining Lean job is the HYP-01 hole re-check control, not a proof lane.

  • README.adoc, EXPLAINME.adoc: lib/ count 154 → 155.

Testing

  • scripts/check-readme-claims.sh: passes (it fails on main).
  • tests/readme-claims-test.sh: 7 passed, 0 failed.

Generated by Claude Code

…oday's proof lanes

The TL;DR and inventory still described 2026-04-22: Agda retired, only
TLA+ gated, the Lean and Idris proofs ungated. Date both headings as
superseded and list the three lanes verify-proofs.yml gates today
(Idris2, Agda, TLC), as the Codex review on #1025 asked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZnmBahbhfkFEP6ark4
check-readme-claims.sh fails on main: #1036 added a lib/ source file and
left the README and EXPLAINME count at 154.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZnmBahbhfkFEP6ark4
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated the architecture overview to reflect the current Elixir source-file count.
    • Marked the gap analysis as historical and superseded, with links to the current proof ledger and convergence plan.
    • Clarified the roles of the Idris2, Agda and TLA+ CI checks, and the remaining Lean workflow job.

The README and EXPLAINME architecture tables now report 155 Elixir source files. The gap analysis marks its 2026-04-22 TL;DR and inventory as historical and superseded, and documents current proof lanes and the Lean job’s role.

Changes: Elixir source-file count

Layer / File(s) Summary
Update architecture table counts
README.adoc, EXPLAINME.adoc
Both architecture tables change the Elixir source-file count from 154 to 155.

Proof gap analysis

Layer / File(s) Summary
Clarify proof status and history
docs/proofs/gap-analysis.adoc
The document links the current proof ledger and convergence plan, describes the Idris2, Agda and TLA+ CI proof lanes and their checks, and identifies the Lean job as a hole re-check control. It marks the TL;DR and proof inventory as superseded historical material dated 2026-04-22.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • hyperpolymath/hypatia#996: Adds the Agda check and migration proof described as part of the CI proof lanes.
  • hyperpolymath/hypatia#1031: Changes the Lean job to a hole re-check control and moves engineering proofs to Idris2, as reflected in the gap analysis.
  • hyperpolymath/hypatia#1036: Adds an Elixir source file, matching the source-count increase recorded in the architecture tables.
Merge Risk: Low · up to 25709

The architecture comparison contains stale counts. The change is mergeable with a small documentation follow-up.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 20:01
@hyperpolymath
hyperpolymath merged commit 7a23e3f into main Nov 10, 2026
98 of 99 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@hyperpolymath
hyperpolymath deleted the claude/gap-analysis-summary branch November 10, 2026 20:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T20:06:16.063865Z 2570967 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25709671f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread EXPLAINME.adoc
[quote, README.adoc]
____
154 Elixir source files — pipeline, rules, VCL, neural, safety, web, merge orchestration
155 Elixir source files — pipeline, rules, VCL, neural, safety, web, merge orchestration

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize the duplicated architecture measurements

After updating this quote, the same Architecture section still says | lib/: 154 | 154 .ex files, 180 defmodule at line 154 and describes those values as gated. The committed tree contains 155 .ex files and 183 defmodule declarations, so EXPLAINME.adoc now contradicts both itself and the repository; update the measured row alongside the quote.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants