Repository navigation
fix(census): prefer a repository's PROOF-STATUS file as its status document - #17
Open
hyperpolymath wants to merge 2 commits into
Open
hyperpolymath wants to merge 2 commits into
hyperpolymath wants to merge 2 commits into
Conversation
…cument build-rows.sh chose one proof-status document per repository by sorting paths alone, so a repo with docs/status/PROOF-NEEDS.adoc and docs/status/PROOF-STATUS.adoc was catalogued under PROOF-NEEDS: an obligations list, not the per-claim record. PROOF-POLICY §8.5 says grades and recheck legs live in the proof-status file, so the catalogue's pointer should reach it. metadatastician/lintel is the case in the committed catalogue. The choice now ranks PROOF-STATUS before PROOF-NEEDS before proof-debt. Within a rank it takes the first path in byte order, under LC_ALL=C so the choice no longer depends on the runner's locale. - tests/census/build_rows_status_test.sh covers four cases: PROOF-STATUS winning where its path sorts later, PROOF-NEEDS over proof-debt, proof-debt alone, and two PROOF-STATUS files. It fails on the old code (case one) and passes on the new. proven-tests.yml runs it beside the atlas tests. - The committed rows are unchanged; the next census run applies the rule. `just catalogue-check` still matches. - docs/architecture/REPOSITORY-MAP.adoc regenerated by scripts/gen-repo-map.sh. It was already stale on main (applied-systems/), and the new tests/census directory adds to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…epo#298) Canon lockstep is red on main and on this PR: standards' canon.lock now records 2.1.5 (metadatastician/standards#1424: gate table 0.3.1 and the applicability policy changed; the criteria did not), while this deed declared 2.1.3. Only the (canon) clause moves: :version 2.1.3 to 2.1.5, and :gates-sha256 2f31f46d… to 5c510bba…. canon.lock marks 2.1.5 draft; this adopts the identity the lockstep gate compares. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs
|
hyperpolymath
marked this pull request as ready for review
November 9, 2026 15:50
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/census/build-rows.shpicks one proof-status document per repository by sorting the paths alone. A repository that has bothdocs/status/PROOF-NEEDS.adocanddocs/status/PROOF-STATUS.adocwas therefore catalogued under PROOF-NEEDS, which is an obligations list, not the per-claim record.standards/3-practice/PROOF-POLICY.adoc§8.5 puts grades and recheck legs in the proof-status file, so the catalogue's pointer should reach that file.metadatastician/lintelis the case in the committed catalogue.The choice now ranks PROOF-STATUS first, then PROOF-NEEDS, then proof-debt. Within a rank it takes the first path in byte order, under
LC_ALL=C, so the choice no longer depends on the runner's locale.Changes
scripts/census/build-rows.sh: ranks the status documents as described.tests/census/build_rows_status_test.sh(new): covers four cases. PROOF-STATUS wins even where its path sorts later; PROOF-NEEDS beats proof-debt; proof-debt is used when it is the only document; and one of two PROOF-STATUS files is chosen. It fails on the old code (first case) and passes on the new.proven-tests.ymlruns it beside the atlas tests.docs/architecture/REPOSITORY-MAP.adoc: regenerated byscripts/gen-repo-map.sh. It was already stale onmain(applied-systems/), and the newtests/census/directory adds to it.The committed rows and catalogue are unchanged: this fixes the rule, and the next census applies it.
render-catalogue.shagainst the committed data still matchesdocs/catalogue/catalogue.adoc.Context: rows due for a refresh
Running
census-repo.shandbuild-rows.shtoday shows the committed rows for two repositories are out of date:PROOF-STATUS.adocdocs/status/PROOF-NEEDS.adoc(committed) /docs/status/PROOF-STATUS.adoc(with this fix)I'd refresh those rows after hyperpolymath/secret-types#26 and metadatastician/lintel#22 merge. Both move their proofs to the canonical
--cubical-compatibleinvocation and record Proof Witness Grades (PWG-3) per claim. Lintel#22 also replaces its placeholder PROOF-STATUS with the real §8.5 record. Refreshing now would catalogue lintel's boilerplate status file.RSR Quality Checklist
Required
bash tests/census/build_rows_status_test.shpasses, and the catalogue check matches.unsafeblocks without// SAFETY:comments.envfiles includedGenerated by Claude Code