Repository navigation
fix(census): pick the proof-status ledger, and keep rows with an empty template list - #25
hyperpolymath wants to merge 2 commits into
Conversation
…y template list build-rows.sh chose each repository's status document by path order, so docs/status/PROOF-NEEDS.adoc won over docs/status/PROOF-STATUS.adoc and resource-algebra's row points at its to-do list rather than its ledger (PROOF-POLICY §8.5's proof-status file). It now ranks PROOF-STATUS, then proof-debt, then PROOF-NEEDS. The committed rows change at the next census run; nothing generated is edited by hand. The template list was read with awk's NR==FNR, which is also true of every line when the list is empty, so an empty list silently dropped every row. It keys on FILENAME == ARGV[1] now. tests/census/status_doc_rank_test.sh covers both (it fails on the old script) and runs in proven-tests.yml beside the atlas tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
No fix exists yet in a PR I could port. The fix is to bring the deed and Generated by Claude Code |
The committed REPOSITORY-MAP.adoc predates applied-systems/ and its subdirectories, so tests/shape/repo_map_determinism_test.sh fails and estate-rules is red on main. Regenerated with `just repo-map` (scripts/gen-repo-map.sh); the determinism test passes under every locale it tries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
|
The fix is in #30, which regenerates the map with
Generated by Claude Code |
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Two bugs in
scripts/census/build-rows.sh, found while checking how the catalogue reflects resource-algebra, typed-wasm and occupancy-types.docs/status/PROOF-NEEDS.adoc(the to-do list) won overdocs/status/PROOF-STATUS.adoc(the ledger PROOF-POLICY §8.5 means), and resource-algebra's row points at the wrong file.NR==FNR. That is also true of every line when the list is empty, so an empty list silently dropped every row.Changes
scripts/census/build-rows.sh:FILENAME==ARGV[1].tests/census/status_doc_rank_test.sh: synthetic raw census inputs checking:It fails on the old script. It runs in
proven-tests.ymlnext to the atlas tests.README.adoc(Reading the catalogue) andCHANGELOG.adoc.Not changed: the committed
catalogue-rows.jsonandcatalogue.adoc. They are generated and must not be edited by hand, so the corrected pointers arrive with the next census run.RSR Quality Checklist
Required
just fmtor equivalent)unsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
CHANGELOGor release notes updatedTesting
bash tests/census/status_doc_rank_test.sh: both checks pass.build-rows.shrestored tomain, the ranking check fails: it picksPROOF-NEEDS, and with an empty template list it returns no rows at all.yqparsesproven-tests.yml.Generated by Claude Code