Repository navigation
fix(proofs): give Agda a writable data directory; run each lane alone (WO 1.4) - #64
Merged
Merged
Conversation
… (WO 1.4) The first Guix lane run (job 130080389181, new pin 8edb9da) built the toolchain in 22 minutes, then failed in the Agda lane: .../agda-2.7.0.1/share/.../lib/prim/_build: createDirectory: permission denied The Guix agda 2.7.0.1 package ships without the interfaces of Agda's own primitive modules, and its store path is read-only, so Agda cannot check any module. It is the same error that breaks Guix's agda-stdlib 2.3. - check-proofs.sh: when Agda's data directory has no lib/prim/_build and cannot be written, the gate copies it to a temporary directory, makes the copy writable and points Agda at it with Agda_datadir, the variable Agda reads. Tested with Agda 2.7.0.1 from Guix as a non-root user, with a read-only data directory without _build: the old gate fails both modules with the CI error; the new gate passes both, and the planted postulate still fails it. A read-only copy given through Agda_datadir reproduces the CI error, which shows that Agda honours the variable. - The workflow runs the Rocq and Lean lanes even when the Agda lane fails, so each lane reports its own result. The failed run skipped both. The packaging defect belongs to Guix, the source; this is the in-repo workaround until its agda package ships the interfaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnDRsCLfZcFcEzvPcM
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A CI fix for work order 1.4. The first Guix lane run at the new pin (job 130080389181) built the toolchain in 22 minutes, then failed in the Agda lane:
The Guix
agda2.7.0.1 package ships without the interfaces of Agda's own primitive modules, and its store path is read-only. So Agda cannot check any module. It is the same error that breaks Guix'sagda-stdlib2.3.Changes
scripts/check-proofs.sh: when Agda's data directory has nolib/prim/_buildand cannot be written, the gate copies it to a temporary directory, makes the copy writable, and points Agda at it throughAgda_datadir, the variable Agda reads.agda-proof-policy.yml: the Rocq and Lean lanes run even when the Agda lane fails, so each lane reports its own result. The failed run skipped both.The defect belongs to the Guix package, its source; this is the in-repo workaround until that package ships the interfaces.
RSR Quality Checklist
Required
Testing
Agda 2.7.0.1 from Guix, run as a non-root user, with a read-only data directory that has no
_build:Agda_datadirreproduces the CI error, which shows that Agda honours the variable.This pull request's lane run is the end-to-end check.
Generated by Claude Code