Repository navigation
feat(golden): just check runs the view checks and proof gates; handoff after stage 2 (WO 2.5) - #72
Merged
Merged
Conversation
…onarCloud) SonarCloud on PR 70: validateBridges had a cognitive complexity of 62 (S3776), the renderer sorted with a nested ternary (S3358), and the entry point wrote and read the two views with `await` inside a loop (S9382). - validateBridges now calls checkRecord, checkEndpoint and checkReview, each a list of `need(condition, message)` lines. Same rules, same messages for each case the tests cover. - The renderer sorts by byte order of the id without a ternary. - build writes, and check reads, the two views with Promise.all; check names every stale view. The 14 registry and bridge tests pass; the views do not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnDRsCLfZcFcEzvPcM
…(WO 2.5) The golden path of the deed (`just test && just quality`) now carries the Mathesis checks: - `just check` = `check-views` (catalogue, census tests, atlas, claims registry and bridges) + `check-proofs` (the Agda, Rocq and Lean gates). - `just test` runs `check` first, then each detected language's tests. - CI runs `just check` in the pinned Guix job (agda-proof-policy.yml), after the three lanes. just 1.56.0 and Bun 1.4.4 come as release archives checked against their published SHA-256; the canon reader is the pinned standards checkout. No new action, so actions.lock is unchanged. - tests/golden/check_controls_test.sh, run after `just check` in CI: in a copy of the tree, a stale catalogue fails `just test`, and an Agda type error in a gated module fails `just check-proofs`. A failure for another reason is a failed control. Locally: `just check-views` passes; the stale-view control passes. The proof control needs Agda 2.7.0.1 (the gate script uses --print-agda-data-dir), so CI is its first run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnDRsCLfZcFcEzvPcM
docs/status/ROADMAP.adoc records that stages 0 to 2 are done, that a new session starts at stage 3, and the open findings for the owner. The census entry of WO 2.1 is marked merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnDRsCLfZcFcEzvPcM
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnDRsCLfZcFcEzvPcM
|
hyperpolymath
marked this pull request as ready for review
November 11, 2026 01:30
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last work order of stage 2 (WO 2.5), with the stage 2 handoff. It also carries the SonarCloud fix that reached #70 after that PR merged.
Changes
09728fb).validateBridgeshad a cognitive complexity of 62 (S3776). It now callscheckRecord,checkEndpointandcheckReview, with the same rules and messages. The renderer sorts without a nested ternary (S3358). The entry point writes and reads the two views withPromise.all(S9382), andchecknames every stale view.11eb27b):just check=check-views(catalogue, census tests, atlas, claims registry and bridges) +check-proofs(the Agda, Rocq and Lean gates).just testrunscheckfirst.just checkin the pinned Guix job, after the three lanes. just 1.56.0 and Bun 1.4.4 come as release archives checked against their published SHA-256, soactions.lockdoes not change. The canon reader is the pinned standards checkout.tests/golden/check_controls_test.shruns afterjust checkin CI, in a copy of the tree. A stale catalogue must failjust test, and an Agda type error in a gated module must failjust check-proofs. A failure for another reason counts as a failed control.91d4ba8):docs/status/ROADMAP.adocrecords that stages 0 to 2 are done, that a new session starts at stage 3, and the open findings for the owner.Checks
just check-views: pass. The stale-view control: pass.--print-agda-data-dir), so this PR's Guix job is the control's first run.check-ijson-jcs.sh --enforce docs: pass. Noasciidoctor --failure-level=WARNwarning on the ROADMAP and the README.Generated by Claude Code