Repository navigation
Finish Windows portability review controls without Git-dependent Cargo tests - #269
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
PR #268 fixed the eight invalid report names and the Chapel writer. Complete its review follow-up: cover Windows superscript-numbered COM/LPT devices and console device names, detect case and file/directory collisions across the tracked inventory, and move the checkout-only check out of ordinary Cargo integration tests.
The explicit CI utility verifies its supplied worktree root before reading Git's index; packaged/vendored Rust tests no longer invoke Git or inspect an enclosing repository. The existing CI-integrity job compiles and runs both unit controls and the real inventory check. Local controls pass, as does the native Git inventory; the initial repair had a successful fresh full Windows checkout and byte-identical historical artifacts.
The live Actions allowlist now includes the already approved canonical namespace-transfer pattern for metadatastician/standards reusable workflows. Existing entries and mandatory SHA pinning were preserved; fresh CI events can exercise the previously startup-blocked Rust, Governance and Hypatia jobs.
Formal-verification scope and remaining hosted evidence are recorded in docs/echo-362-portability.adoc. Addresses the CodeRabbit and Codex findings on #268 and the scanner-portability portion of hyperpolymath/echo-types#362.