Skip to content

fix(deps): update h2, rustls and tokio past open RustSec advisories - #170

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/admiring-meitner-8qkxac-deps
Nov 5, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/admiring-meitner-8qkxac-deps

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

GitHub has been reporting a moderate Dependabot alert on main (#15). cargo audit on the root Cargo.lock found four advisories. All four are fixed by semver-compatible patch releases.

Crate From To Advisory
h2 0.4.15 0.4.20 RUSTSEC-2026-0258: unbounded empty DATA frames
rustls 0.23.40 0.23.46 RUSTSEC-2026-0285: TLS 1.3 handshake messages accepted across encryption levels
RUSTSEC-2026-0348: brotli certificate decompression can allocate up to 1 GiB before authentication
RUSTSEC-2026-0346: Debug impls expose TLS secrets
rustls-webpki 0.103.13 0.103.16 (moves with rustls)
tokio 1.52.3 1.54.1 RUSTSEC-2026-0386: AsyncFd::new is unsound (warning only; panll never calls AsyncFd)

What

Only Cargo.lock changes, via cargo update -p h2 -p rustls -p tokio. Cargo.toml is untouched.

Checks

  • cargo audit: no vulnerabilities. One allowed warning remains: instant is unmaintained (RUSTSEC-2024-0384). It comes in through notify 7, and removing it needs a major notify upgrade, so it is out of scope here.
  • tools/pcc/Cargo.lock: already clean.
  • cargo fmt --all -- --check: clean.
  • cargo clippy --locked --all-targets -- -D warnings: clean.
  • cargo clippy --locked --features gossamer --all-targets -- -D warnings: clean (stub libgossamer).
  • cargo test --locked --lib: 294 passed.

Generated by Claude Code

cargo audit on the root Cargo.lock reported four advisories, all fixed
by semver-compatible patch releases:

- h2 0.4.15 -> 0.4.20: RUSTSEC-2026-0258 (unbounded empty DATA frames)
- rustls 0.23.40 -> 0.23.46 (rustls-webpki 0.103.13 -> 0.103.16):
  RUSTSEC-2026-0285 (TLS 1.3 handshake messages across encryption
  levels), RUSTSEC-2026-0348 (brotli certificate decompression
  allocates up to 1 GiB before authentication), RUSTSEC-2026-0346
  (Debug impls expose TLS secrets)
- tokio 1.52.3 -> 1.54.1: clears RUSTSEC-2026-0386 (AsyncFd::new is
  unsound). panll does not call AsyncFd, but the update is
  semver-compatible.

Lockfile only. After the update cargo audit reports no
vulnerabilities; one warning remains: instant is unmaintained
(RUSTSEC-2024-0384), pulled in by notify 7, and removing it needs a
major notify upgrade. tools/pcc/Cargo.lock was already clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4f778327-96ab-4be7-85e2-e0242829eed5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • No new commits to review - use @coderabbitai full review for a full pass
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@linear-code
linear-code Bot marked this pull request as ready for review November 4, 2026 23:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T23:50:56.929558Z 4a6a1e6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

Seven workflows hit startup_failure on 4a6a1e6 and ran no jobs: E2E, Build Validation, Rust CI, Governance, Secret Scanner, Fork governance and Dogfood Gate. This PR didn't cause that:

  • The PR changes only Cargo.lock, which can't affect how a workflow starts.
  • On 2 Nov, Dependabot's chore(deps): bump rustls from 0.23.40 to 0.23.46 in the cargo group across 1 directory #169 made the same rustls 0.23.40 → 0.23.46 bump, and E2E passed (run 41424662284). The failures began between then and now.
  • What still starts uses only GitHub-owned actions or cicd-suite: CodeQL, estate-audit, SonarCloud, semgrep and GitGuardian, all green. The workflows that fail use third-party actions (Swatinem/rust-cache, goto-bus-stop/setup-zig, dtolnay/rust-toolchain) or metadatastician/standards reusables. That points to a change in the repo's allowed-actions setting, or a lockfile check, since 2 Nov.

No fix exists in this repo yet. The startup error text is on each run page (for example https://github.com/hyperpolymath/panll/actions/runs/41936669786), but the API doesn't return it. I'm not re-running anything: a startup failure fails the same way every time.

Locally, cargo audit is clean, fmt and clippy pass (library and desktop binary), and all 294 tests pass.


Generated by Claude Code

@hyperpolymath
hyperpolymath merged commit 95a69be into main Nov 5, 2026
8 checks passed
@hyperpolymath
hyperpolymath deleted the claude/admiring-meitner-8qkxac-deps branch November 5, 2026 15:41
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Add Carrot credits or activate Agent usage billing to use Autofix

hyperpolymath added a commit that referenced this pull request Nov 5, 2026
## Why

These are two owner decisions:
- **Retire the ReScript scanner in `tools/pcc`.** #107 removed the
`.res` sources it read, so every frontend-wiring check it ran was
reporting a false "missing" with "Repairability: safe".
- **Turn off the Gitea mirror for now.** `vars.GITEA_HOST` is unset, so
the Gitea job failed on every push to main.

## What

**`tools/pcc`**
- `src/rescript_scanner.rs` is deleted (308 lines).
- `scanner.rs`: the seven checks that read `.res` files now return a
"retired" result, with the reason and a pointer to #148. Those checks
are registry, model include/slice, msg type/variant, view route and
contractiles. The test-bundle check doesn't read frontend sources and is
unchanged.
- `propagator.rs`: a failed check against a `.res` file is reported as
`Check retired: … removed in #107; an AffineScript scanner is tracked in
#148` and marked **Manual**. So `panel repair` no longer plans ReScript
edits; it now says "No safe repairs available".

**`.github/workflows/mirror.yml`**
- The workflow no longer passes `GITEA_SSH_KEY`. The shared mirror
workflow skips any forge whose key isn't passed (see its header), so
only Gitea stops. The other forges are unchanged.

**Docs:** the PCC row in `PROOF-NEEDS.adoc`, and the CHANGELOG.

## Checks

- `cargo build --locked --release` in `tools/pcc`, the same build Build
Validation runs: passes.
- `panel verify` runs against the tree and shows the retired reason on
each ReScript check. `panel repair --panel Aerie` reports "No safe
repairs available".
- `rustfmt --check` on `scanner.rs`: clean. The rest of pcc was already
unformatted on main, so I left it alone to keep this diff small.
- pcc has existing clippy warnings that predate this PR: 13 on main, 6
here. CI doesn't run clippy on pcc.

## CI note

Most workflows currently fail at startup because of the repo's new
Actions policy (owner-only, GitHub-created, or Marketplace-verified).
That blocks third-party actions and the `metadatastician/standards`
reusables. It affects every PR; see #170. This PR doesn't change it.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants