Repository navigation
ci(gitleaks): ignore the renamed api-reference placeholder fingerprints - #183
Conversation
The full-history gitleaks pass reports generic-api-key twice in docs/api-reference.adoc at f50c0aa (lines 46 and 86). They are the same placeholder snapshot id `abc123-def456` that .gitleaksignore already ignores under the file's old name, docs/api-reference.md, and #140 replaced it in the current tree. Add the two exact fingerprints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnmBahbhfkFEP6ark4
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
Brings in #183's .gitleaksignore fingerprints so the full-history scan re-runs against the trusted base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnmBahbhfkFEP6ark4
Why
With a working scanner caller (#182), the full-history gitleaks pass reports 2
generic-api-keyfindings, indocs/api-reference.adocatf50c0aa, lines 46 and 86 (job 130147248330). The current tree scans clean.Both lines are the placeholder snapshot id
abc123-def456in the API examples..gitleaksignorealready ignores the same placeholder under the file's old name,docs/api-reference.md, and #140 replaced it in the current tree. The rename to.adocgave it new fingerprints.What
.gitleaksignoregains the 2 exact fingerprints (commit:file:rule:line), and its comment names the renamed file. Each entry suppresses only that commit, file and line.Merge order
The scanner refuses any PR that changes
.gitleaksignore("PR ignore file differs from trusted base"), so the ignore list cannot change inside a scanned PR.scan / gitleaksis the required check onmain, and on this branch the old caller still fails at startup. So this PR needs the owner's merge. After it lands, #182 mergesmainand itsscan / gitleaksshould pass.Generated by Claude Code