Repository navigation
Repin the self-callers to the published name admission - #96
Merged
Merged
Conversation
PR 94 is on main as 1fd5e63. From that commit the suite admits hyperpolymath/proven-cicd-and-workflows as a caller name. Move the two self-callers to that name and that commit: - secret-scanner.yml called hyperpolymath/proven-cicd at a12b2b4. After this change no workflow in this repository calls the proven-cicd repository. - creusot-live-canary.yml called the new name at 6c6d772, whose resolver refuses that name. Move the call, the ancestry check and both literals in tests/creusot-live-canary.sh together. - config/workflow-lock-scope.json: the reason text named the PR70 pin. Make it name a published suite commit. Two minor review items from PR 94: - README.adoc: tell consumers to pin a commit that contains the migrated main-estate-audit.yml (1fd5e63 or later). - templates/track-estate-audit.yml: extract and replace a SHA only in a complete uses: reference to this suite under hyperpolymath. The earlier pattern had no owner prefix, and sed replaced the SHA in the whole file. Tracker step run on fixtures (bare, single-quoted and double-quoted callers; a fork reference, a near-name owner and an unrelated action at the same SHA): the 3 suite callers move to the new name and SHA, the other 3 references stay, and a second run reports changed=0. The step from main rewrites all 3 of the other references. Local checks: tests/suite-source-compatibility.sh and tests/published-scanner-pin.sh pass through a yq adapter; both --check builders pass; the pin is an ancestor of origin/main. The canary and the yq-based tests need the hosted run. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6 Signed-off-by: Claude <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
hyperpolymath
marked this pull request as ready for review
November 10, 2026 16:58
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow-up 1 of #94. The owner asked for the repin and for the two Minor review items from #94.
Why
#94 is on
mainas1fd5e6371a50f0fc3687206a5adca0cdf7b39aa6. From that commit the suite admitshyperpolymath/proven-cicd-and-workflowsas a caller name. A self-caller can use the new name only with a pin that includes that admission and is onmain. That commit is the first one.What
Repin
.github/workflows/secret-scanner.ymlhyperpolymath/proven-cicd@a12b2b4hyperpolymath/proven-cicd-and-workflows@1fd5e63.github/workflows/creusot-live-canary.yml6c6d772, which refuses that name1fd5e63tests/creusot-live-canary.shmove with the call.config/workflow-lock-scope.json: the reason text named the PR70 pin. It now names a published suite commit.proven-cicdrepository.Two Minor items from the #94 review
README.adoc: one sentence tells consumers to pin a commit that contains the migratedmain-estate-audit.yml(1fd5e63or later).templates/track-estate-audit.yml: the tracker now extracts and replaces a SHA only in a completeuses:reference to this suite underhyperpolymath. The earlier pattern had no owner prefix, andsedreplaced the SHA in the whole file.Hosted checks on
3e5f763All 27 check runs completed: 25 passed, and CodeRabbit and CodeQL were neutral.
scan / gitleaks,scan / rust-secretsandscan / shell-secretspass (run 42859834371).Detect Creusot obligations,Creusot theatre gate,Creusot proofs (cargo creusot prove)andCreusot verdictall pass. The proof job ran for about 9 minutes. These checks failed on Admit the renamed repository and call it by its new name #94, where the pin refused the new name.Locked fixture and published sourcepasses, so the new pin is onmain.Evidence (local)
changed=0.main: it rewrites all 3 of the other references.tests/suite-source-compatibility.shandtests/published-scanner-pin.shpass. They ran through an adapter that drops-o=json, because theyqon this machine is the jq-based one.--checkbuilders pass.origin/main.After merge
🤖 Generated with Claude Code
https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6