Repository navigation
docs(wager): Stage 8, 3 corrections from the review of #101 - #102
Merged
Merged
Conversation
- Poly/Statements.agda: the comment of T8-Closed said that T0 to T6 apply to each closed instance. That was too strong. The comment now follows DC-8.3. The statement did not change. - Poly/Proofs.agda: the header names each proof of the module. - TOOLCHAIN.adoc: the last row of the gate watch of Stage 8 records the run with 91 files only. scripts/check-proofs.sh agda: PASS, 96 modules. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
hyperpolymath
marked this pull request as ready for review
November 11, 2026 01:13
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hyperpolymath
enabled auto-merge (squash)
November 11, 2026 01:13
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A follow-up of #101, which is merged. It has the 3 corrections that the automated review of #101 asked for. Each is a comment or a record. No statement and no proof changes.
Changes
Wager/Poly/Statements.agda: the comment ofT8-Closedsaid that T0 to T6 apply to each closed instance. That was too strong. The comment now follows DC-8.3: a theorem about each typed target term applies under its own hypotheses; T3, T5 and T6 are about the translation of a source program; T2 and T4 are about types. The type of the statement did not change.Wager/Poly/Proofs.agda: the header names each proof of the module.Wager/TOOLCHAIN.adoc: the last row of the gate watch of Stage 8 records the run with 91 files only, and points to the row of the side item for the run with 96 files.Not in this pull request: the failed check "Deposit findings for gitbot-fleet" on #101. It is CI work, and this session does proof work only.
RSR Quality Checklist
Required
scripts/check-proofs.sh agdapasses with 96 modules, andscripts/check-proof-status.shpasses.just testandjust qualitywere not run..envfiles includedTesting
scripts/check-proofs.sh agda: PASS, 96 gated modules.scripts/check-proof-status.sh: PASS.Generated by Claude Code