Skip to content

ci(lint): the SPDX rule stops at an indented workflow body also #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Nov 10, 2026
Merged

ci(lint): the SPDX rule stops at an indented workflow body also #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e0e21a
ci(lint): the SPDX rule stops at an indented workflow body also
claude Nov 10, 2026
0ae3fd7
Merge branch 'main' into claude/spdx-rule-indented-body
hyperpolymath Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/workflow-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
[ -f "$file" ] || continue
# actions-lock may prepend its own comment. Require the licence
# in the leading comment block, before the workflow body.
if ! awk '/^# SPDX-License-Identifier:/ { found=1 } /^[^#[:space:]]/ { exit } END { exit !found }' "$file"; then
if ! awk '/^# SPDX-License-Identifier:/ { found=1 } /^[[:space:]]*[^#[:space:]]/ { exit } END { exit !found }' "$file"; then
echo "ERROR: $file missing SPDX header"
failed=1
fi
Expand Down Expand Up @@ -72,7 +72,7 @@
fi
echo "All workflows have permissions declared"

- name: Check SHA-Pinned Actions

Check warning on line 75 in .github/workflows/workflow-linter.yml

View workflow job for this annotation

GitHub Actions / Hypatia neurosymbolic scan 

[hypatia] workflow .github/workflows/workflow-linter.yml:75 step `Check SHA-Pinned Actions` swallows non-zero exit via `|| true` — failures will be masked
env:
GH_TOKEN: ${{ github.token }}
run: |
Expand All @@ -90,7 +90,7 @@
# No lockfile: every uses: must carry an inline SHA pin.
unpinned=$(grep -rnE "^[[:space:]]+uses:" .github/workflows/ | \
grep -v "@[a-f0-9]\{40\}" | \
grep -v "uses: \./\|uses: docker://\|uses: actions/github-script" || true)

Check warning on line 93 in .github/workflows/workflow-linter.yml

View workflow job for this annotation

GitHub Actions / Hypatia neurosymbolic scan 

[hypatia] workflow .github/workflows/workflow-linter.yml:93 pins container `docker://\|uses:` by tag — tag is mutable; pin by sha256 digest instead

if [ -n "$unpinned" ]; then
echo "ERROR: Found unpinned actions:"
Expand Down
Loading