Repository navigation
fix(ci): restore the Gitleaks security check after standards ownership transfer - #134
hyperpolymath wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|



Problem (observed)
VCL-UT's
Secret Scannerworkflow is not slow in recent PRs; it fails before its first job starts. For example run 40966408150 completed immediately withjobCount: 0, leaving no Gitleaks scan result. The wrapper still callshyperpolymath/standardsat an obsolete reusable pin and passes all secrets to a reusable that declares no secrets. A zero-job failure is never a successful security check.Change (one workflow file)
metadatastician/standards/.github/workflows/secret-scanner-reusable.ymlat verified immutable commit8e48b1caade08a552646adeab66558ac43b4360d.secrets: inherit,actions: readandsecurity-events: write; keep the requiredcontents: readunder the called job, matching the reusable's explicit permission contract.hyperpolymath/vcl-utselected-actions policy was separately repaired to permit the narrowly scoped canonical reusable while retaining SHA pinning.Evidence
actionlint .github/workflows/secret-scanner.ymlpasses,git diff --checkpasses, and signed commit569aa73has good SSH signature.CI should now show actual
scan / gitleaks,scan / rust-secrets, andscan / shell-secretsjobs. Do not merge assuming the fix works solely because a zero-job run disappears; observe job-level execution.