Skip to content

docs(clade): uuid follows the forge path, it is not immortal - #141

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/clade-uuid-follows-forge-path
Nov 10, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/clade-uuid-follows-forge-path

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Comment-only correction. The CLADE status comment said the uuid is immortal. gv-clade-index ADR 0007 (accepted 2026-11-10) makes the uuid follow the forge path: a move or rename mints a new one, and a phase change never does.

A2ML is retired for new content. Correcting a factually wrong comment in an existing file is an edit, not new content.

Changes

  • .machine_readable/CLADE.a2ml: "uuid is immortal" → "uuid follows the forge path (a move or rename mints a new one, gv-clade-index ADR 0007; a phase change never does)"; "A rename is NOT a phase change" → "A prefixed-name (clade code) change is NOT a phase change". The paragraph is re-wrapped at 80 columns. No data values change. The wording is the same as in the correction PRs already merged across the estate.

RSR Quality Checklist

Required

  • Tests pass (just test or equivalent): not run locally. Comment-only change, left to CI.
  • Code is formatted (just fmt or equivalent): n/a, no code
  • Linter is clean (no new warnings or errors): n/a, no code
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions
  • SPDX license headers present on all new/modified source files (not touched)
  • No secrets, credentials, or .env files included

Testing

The diff is one comment paragraph in one file. Every line is ≤80 characters. The commit is signed.


Generated by Claude Code

The CLADE status comment said the uuid is immortal. gv-clade-index
ADR 0007 (accepted 2026-11-10) makes the uuid follow the forge path:
a move or rename mints a new one, and a phase change never does. A
prefixed-name (clade code) change still does not remint.

Comment-only correction. No data values change. A2ML is retired for
new content, but correcting a factually wrong comment in an existing
file is an edit, not new content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmTcNdC1jL1Vp3qW9H
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that moving or renaming an item mints a new UUID, while changing its phase does not. Prefixed-name changes instead add the previous name to the aliases list without changing the UUID or phase.

The lifecycle comment now states that UUIDs follow the forge path. A move or rename mints a new UUID. It distinguishes prefixed-name changes from phase changes.

Changes: Lifecycle UUID documentation

Layer / File(s) Summary
Document UUID lifecycle
.machine_readable/CLADE.a2ml
The comment states that moves or renames mint a new UUID. Phase changes do not alter the UUID, and the old prefixed name goes to aliases[].

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to dc274

The clarification does not change data or runtime behavior. No actionable merge risk remains.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly describes the main change: updating the CLADE documentation to state that UUIDs follow the forge path rather than being immortal.
Description check Passed The description includes the required Summary, Changes, RSR Quality Checklist and Testing sections. It explains the change and reports that tests were not run locally. The Screenshots section and some…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Summary, Changes, RSR Quality Checklist and Testing sections. It explains the change and reports that tests were not run locally. The Screenshots section and some applicable checklist items are omitted, but the description is mostly complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

.machine_readable/CLADE.a2ml: 1

19-19: Major · Data Integrity & Integration · Heavy lift

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Correct the declared primary forge path.

This record names hyperpolymath/vcl-total, but this repository is hyperpolymath/vcl-ut. The README identifies vcl-total as the crate name. (raw.githubusercontent.com)

The registry uses the GitHub path for repository identity, so this declaration points to the wrong repository. Update the primary path and names, and derive the UUID from the correct path. (github.com)

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6d248e28-82dc-4901-b55b-c36b48052e4e
Commits

Reviewing files that changed from the base of the PR and between 5b10cb0 and dc274f8.

Files selected for processing: 1

  • .machine_readable/CLADE.a2ml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details

Context from checks skipped due to timeout: 27

  • GitHub Check: CodeRabbit
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: idris2 0.8.0 --build vclut-core
  • GitHub Check: attest — clippy / tests
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: recompute-wasm — clippy / tests
  • GitHub Check: idris2 0.8.0 --build vclut-abi
  • GitHub Check: Validate Echidna prover catalogue
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Validate K9 contracts
  • GitHub Check: vcltotal-parse — panic-free / clippy / tests
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Groove manifest check
  • GitHub Check: license-policy
  • GitHub Check: Dependency audit
  • GitHub Check: ffi/zig — fmt / header / zig build test
  • GitHub Check: E2E structural validation
  • GitHub Check: Aspect tests
  • GitHub Check: openssf-compliance
  • GitHub Check: panic-attack assail
  • GitHub Check: Root workspace tests
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: license-policy
Additional context used

Code guidelines: 1

.github/copilot-instructions.md — auto-discovered
Path-based instructions: 1

Source excerpt: Never create these in the repo root: STATE.a2ml, META.a2ml, ECOSYSTEM.a2ml, AGENTIC.a2ml, NEUROSYM.a2ml, PLAYBOOK.a2ml.

CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • .machine_readable/CLADE.a2ml

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 23:17
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T23:17:29.361026Z
We couldn’t complete this review. Comment @codex review to try again.
dc274f8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@hyperpolymath
hyperpolymath merged commit eb995b2 into main Nov 10, 2026
33 of 34 checks passed
@hyperpolymath
hyperpolymath deleted the docs/clade-uuid-follows-forge-path branch November 10, 2026 23:19

Copy link
Copy Markdown
Owner Author

On CodeRabbit's Major note (line 19, forge path says vcl-total). I checked it. The finding is real, but it isn't caused by this PR, and the fix is a data change that doesn't belong in this one.

  • The uuid (581e7dc6-…) is already right for this repo: it equals UUIDv5(URL, github.com/hyperpolymath/vcl-ut).
  • The fields still on the old name are canonical-name = "vcl-total", prefixed-name = "rm-vcl-total", and all three [forges] paths.

So a rename from vcl-total to vcl-ut was only half applied. Completing it means updating those fields, and, per ADR 0006/0007, deciding whether rm-vcl-total goes to aliases[]. That changes identity data, so this comment-only PR leaves it alone. I've flagged it to the owner for a separate fix.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants