Repository navigation
fix(ci): remove pre-existing unused RAM promotion fields - #335
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
| Layer / File(s) | Summary |
|---|---|
Peer capability test data rust-core/verisim-api/src/groove.rs |
The test initialises peer capabilities as an array instead of a vector. Matching logic and the expected result remain unchanged. |
Promotion state
| Layer / File(s) | Summary |
|---|---|
Use the map key for modality rust-core/verisim-octad/src/ram_promotion.rs |
PromotedState no longer stores a separate modality field. Promotion continues to use modality as the map key. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Refactor
Merge Risk: 
ac477
-
The cleanup is safe to merge.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title uses the conventional-commits prefix 'fix(ci):' and names the change as removing RAM promotion fields. The changeset removes an unused HashSet import and the redundant PromotedState.modality… Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title uses the conventional-commits prefix 'fix(ci):' and names the change as removing RAM promotion fields. The changeset removes an unused HashSet import and the redundant PromotedState.modality field in ram_promotion.rs, which the PR objectives describe as fixing strict clippy (all-targets) diagnostics. The title states what changes rather than that CI passes. However, the title says 'unused RAM promotion fields' (plural) while the diff removes one field and one import, and the groove.rs test change is not mentioned. The title is therefore partially related: it covers the main change but omits the second commit and the 'fix' framing is arguable since it addresses lint failures.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
📝 Generate docstrings
-
- 🤖 Coding Agent task started for docstring generation.
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
✅ Coding Agent task started: View task and status The task will inspect the CI failures, validate its fix, and commit the fix to this branch automatically.
⏭️ Checks skipped: 10 · already failing on `main` (not caused by this PR)
|
|
🤖 Completed: Generate docstrings for PR #335 — View commit |
…verage, and update UUID examples to v8
|
…tions and v1 consumer contract (#337) Independent code-grounded reconnaissance as of main `5876bc67e8962e3b276fb0161664e0b3a420a64c`. Adds three review documents: - `docs/reviews/2026-10-29-verisimdb-as-built-recon.adoc` — source-derived architecture, conceptual ER, eight-modality/persistence matrix, actual lifecycle, P0/P1/P2 discrepancy register, tests and formal proof obligations, independent Mathesis/QuandleDB/JanusKey/Marches reuse, prioritized engineering programme. - `docs/consumer-interface-contract-v1-observed.adoc` — actual flatten-vs-nested HTTP ABI, operations, HTTP statuses, feature/configuration guarantees and explicit non-guarantees. - `docs/reviews/2026-10-29-hypatia-verified-handover.adoc` — only verified downstream integration facts. No rewrite of the Octad schema; accepted generic term **modality profile** distinguished from **modality set** and **consonance subject**. References separate code fixes #333, #334, #335, #336. Makes no soundness claims beyond observed source/test status. No data mutation.
The current strict
clippy (all-targets)job fails onrust-core/verisim-octad/src/ram_promotion.rseven for unrelated PRs (#333 and #334).Two diagnostics:
HashSetis imported but never used.PromotedState.modalityis never read; the containingPromotionManager.promotedmap already keys entries byModality.Remove the unused import and redundant private field/initializer. No storage format, behaviour, or API change. Await CI. This is independent of the WAL and API integrity changes.
Summary by CodeRabbit