Repository navigation
chore(ios): give git worktrees the Honeycomb key - #58
Merged
Merged
Conversation
apps/ios/Local.xcconfig is gitignored, so a new worktree lacked it and its iOS builds silently ran without the Honeycomb ingest key. A lefthook post-checkout job now symlinks the main checkout's Local.xcconfig into a worktree when it's created (scripts/link-local-config.sh, also runnable by hand), and a pre-build script warns when a build has no key. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDM2pVeSUgwNr2EUZAajLo
|
🚀 Preview deployed: https://preview-58.tablo.run |
i11v
marked this pull request as ready for review
October 17, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ilnur · project thread
Before:
apps/ios/Local.xcconfig, which holds the Honeycomb ingest key, is gitignored, so a new git worktree doesn't get it.#include? "Local.xcconfig"then silently includes nothing, and the worktree's iOS build runs with no key and sends no telemetry, with no sign that anything is wrong.After: creating a worktree symlinks the main checkout's
Local.xcconfiginto it. Any build that still has no key (a temp copy, a CI build) shows the Xcode build warning "HONEYCOMB_API_KEY is empty, so this build sends no telemetry".How
scripts/link-local-config.shfinds the main checkout fromgit rev-parse --git-common-dirand symlinksapps/ios/Local.xcconfiginto the current worktree when it is missing there. It does nothing in the main checkout or when the file already exists, and you can run it by hand in a worktree made before this change.lefthook.ymlgains apost-checkoutjob that runs the script, sogit worktree addtriggers it. The installed hook calls lefthook by the main checkout's absolute path, so it also works in a fresh worktree with nonode_modules.apps/ios/project.ymlpre-build script prints the warning whenHONEYCOMB_API_KEYis empty.apps/ios/README.mddocuments both.Tested here: the script is a no-op in the main checkout, links once in a worktree and is idempotent on a second run. After
lefthook install, a plaingit worktree addcreated the symlink through the hook. I couldn't run XcodeGen or Xcode here, so the pre-build script is checked only by the iOS CI build.After merging: run
bun install(orbunx lefthook install) once in the main checkout to install the newpost-checkouthook. For worktrees that already exist, runscripts/link-local-config.shin each.Generated by Claude Code