Skip to content

Stop printing GitHub secrets to the server log #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarstelfox merged 1 commit into from
Sep 30, 2026
Merged

Stop printing GitHub secrets to the server log #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/githubHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const HooksController = {

var secret = req.query.secret;
if (secret !== config.github.hook_secret) {
var m = 'Invalid Hook Secret: ' + secret;
var m = 'Invalid Hook Secret';
hooksDebug(m);
console.error(m);
return res.status(401).send('Invalid POST');
Expand Down
2 changes: 0 additions & 2 deletions lib/git-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import { noopPacer } from './pacer.js';
const MyOctokit = Octokit.plugin(throttling, retry);
const gitDebug = debug('pulldasher:github');

console.log(config.github);

const github = new MyOctokit({
auth: config.github.token,
// Auto-retry transient 5xx/network failures (the throttle plugin only covers
Expand Down
Loading