Conversation
The command is defined in msp_protocol_v2_inav.h and answered in fc_msp.c, but the registry never listed it, so check_msp.py fails on maintenance-10.x and on every pull request that runs the MSP consistency workflow.
MSP2_INAV_ESC_SRXL2_STATUS and MSP2_INAV_ESC_SRXL2_CALIBRATE came in with iNavFlight#11947 without an entry in msp_messages.json, which is two of the three commands check_msp.py reports as missing.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can keep summaries lean with Finding overflow, which tucks the rest behind 'View more' |
PR Summary by QodoRegister missing MAG and SRXL2 MSP commands
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
Thanks — this fixes the red MSP consistency check on One small addition, if you don't mind: Thanks! |
The new SRXL2 entries link to srxl2CalPhase_e and srxl2CalResult_e, which the enum reference did not have yet. Regenerated with the scripts in src/utils, so it also picks up what was merged since the last run: the 10.0.0 version, the other SRXL2 enums, PWM_TYPE_SRXL2 and FUNCTION_ESC_SRXL2, BOXTHRUSTREVERSE, the secondary gyro blackbox condition, the LED rainbow overlay, and navFwWpTurnMode_e in place of wpFwTurnSmoothing_e.
What this fixes
check_msp.pyfails onmaintenance-10.x, so the MSP consistency workflow goes red on every pull request that touches MSP, whatever the pull request does. Three commands are defined inmsp_protocol_v2_inav.hand answered infc_msp.cbut have no entry inmsp_messages.json:MSP2_INAV_ESC_SRXL2_STATUS(0x2233) andMSP2_INAV_ESC_SRXL2_CALIBRATE(0x2234), which came in with my Spektrum Smart ESC (SRXL2) motor output #11947 and which I should have added then;MSP2_INAV_MAG_UNALIGNED(0x2232), which isn't mine, but without it the check stays red.What I changed
An entry for each, written from the handlers in
fc_msp.cand the enums inmotor_srxl2.h, withREADME.mdregenerated bygen_msp_docs.sh. TheMAG_UNALIGNEDentry is a commit of its own, so it can be dropped if its author would rather write it.The registry version goes from 2.1.1 to 2.1.2: new entries inside the current schema, which the versioning rule counts as a patch.
Testing
check_msp.pypasses ("281 C definitions match 282 JSON definitions"), andgen_msp_docs.shleavesREADME.mdunchanged after the commit, which is what the workflow compares.#11979 also bumps the registry version, so whichever of the two goes in second will need that line rebased.