Repository navigation
Add deployment-ready Docker setup - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a deployment-oriented Docker setup for running the existing gateway/worker mesh in a more production-like configuration (private workers + public gateway), along with supporting docs, a smoke check script, and CI image build coverage.
Changes:
- Add production-style compose file (
docker-compose.prod.yml) plus.env.examplefor environment-driven configuration. - Add
scripts/smoke_check.pyandMakefiletargets to validate a running stack and streamline common dev workflows. - Add Docker healthchecks and extend CI to build gateway/worker images.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
worker/Dockerfile |
Adds Python runtime env defaults and a container healthcheck for the worker service. |
gateway/Dockerfile |
Adds Python runtime env defaults and a container healthcheck for the gateway service. |
docker-compose.prod.yml |
Adds a “production-style” compose setup (no public worker/redis ports, env-based gateway config). |
.env.example |
Provides a template for gateway/worker-related environment variables. |
.dockerignore |
Reduces Docker build context (omits git/venv/caches/results/runs). |
scripts/smoke_check.py |
Adds a small end-to-end validation script (health + predict + metrics + workers). |
README.md |
Documents how to run the production-style compose locally and where deployment notes live. |
docs/deployment.md |
Adds provider-neutral deployment notes and expected service topology/env. |
Makefile |
Adds convenience targets for tests, compose runs, smoke check, and local image builds. |
.github/workflows/test.yml |
Adds a CI job that builds the gateway/worker Docker images. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+18
| def get_json(url: str, timeout: float = 2.0) -> dict: | ||
| with request.urlopen(url, timeout=timeout) as response: | ||
| return json.loads(response.read().decode("utf-8")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds deployment-oriented Docker files, a production compose file, environment example, smoke check script, deployment notes, and Docker image builds in CI. This does not claim the app is hosted yet; it makes the current gateway/worker mesh ready to deploy to a provider with private service networking.\n\nChecked locally:\n- python -m pytest -q\n- python -m py_compile scripts/smoke_check.py bench/replay_traffic.py bench/run_scenarios.py bench/run_bench.py gateway/app/.py worker/app/.py training/train_text_model.py\n- YAML parse check for docker-compose.yml, docker-compose.prod.yml, and workflow\n- local uvicorn smoke check with scripts/smoke_check.py\n\nNote: Docker is not installed in this local shell, so image builds are verified by GitHub Actions.