Skip to content

253 refactor informationneeds - #255

Open
dkkdark wants to merge 23 commits into
mainfrom
253-refactor-informationneeds
Open

dkkdark wants to merge 23 commits into
mainfrom
253-refactor-informationneeds

Conversation

@dkkdark

@dkkdark dkkdark commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@dkkdark dkkdark linked an issue Jun 23, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Current Branch Main Branch
Coverage Badge Coverage Badge

@dkkdark
dkkdark requested a review from NoB0 June 23, 2026 15:55

@NoB0 NoB0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a few points to clarify, see questions above. And some nits to look at.

Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/simulator/agenda_based/interaction_model.py Outdated
Comment thread usersimcrs/simulator/agenda_based/interaction_model.py Outdated
Comment thread usersimcrs/simulator/user_simulator.py Outdated
Comment thread usersimcrs/simulator/user_simulator.py Outdated
Comment thread usersimcrs/simulator/user_simulator.py Outdated
@dkkdark
dkkdark requested a review from NoB0 June 30, 2026 12:16

@NoB0 NoB0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a few questions to clarify before I review all the documents. Based on our discussion, the update of the information need could be seen as similar to the dialogue state tracking. However, the logic and implementation are quite different; is there a specific reason for this? In general, I would argue for harmonization so it is easier to understand.

Comment thread usersimcrs/core/information_need.py
Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/information_need_management/information_need.py Outdated
Comment thread usersimcrs/core/information_need.py Outdated
Comment thread usersimcrs/simulator/information_need/interface.py Outdated
Comment thread usersimcrs/simulator/information_need/interface.py Outdated
Comment thread usersimcrs/simulator/information_need/interface.py Outdated
@dkkdark
dkkdark requested a review from NoB0 July 21, 2026 12:22

@NoB0 NoB0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few open questions.

Comment thread tests/core/test_information_need.py Outdated
Comment thread usersimcrs/information_need_management/information_need_tracker.py
Comment thread usersimcrs/information_need_management/information_need_tracker.py
Comment thread usersimcrs/information_need_management/information_need.py Outdated
Comment thread usersimcrs/information_need_management/information_need_trackers/llm_interface.py Outdated
Comment thread usersimcrs/simulator/user_simulator.py Outdated
Comment thread usersimcrs/simulator/llm/llm_single_prompt_user_simulator.py
Comment thread usersimcrs/simulator/llm/llm_dual_prompt_user_simulator.py
@dkkdark
dkkdark requested a review from NoB0 August 4, 2026 14:19

@NoB0 NoB0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still few points to clarify and improve.

Comment thread tests/conftest.py
Comment thread usersimcrs/information_need_management/information_need.py Outdated
Comment thread usersimcrs/information_need_management/information_need.py Outdated
Comment thread usersimcrs/information_need_management/information_need_tracker.py
Comment thread usersimcrs/information_need_management/information_need_tracker.py
@dkkdark
dkkdark requested a review from NoB0 August 11, 2026 08:39
Comment thread usersimcrs/simulator/llm/llm_dual_prompt_user_simulator.py Outdated
Comment thread usersimcrs/simulator/llm/llm_single_prompt_user_simulator.py Outdated
Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py
@dkkdark
dkkdark requested a review from NoB0 August 11, 2026 14:46

@NoB0 NoB0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor InformationNeeds

2 participants