IBX-12039: Migrated versions tab tables to ibexa.Table component#1960
IBX-12039: Migrated versions tab tables to ibexa.Table component#1960ciastektk wants to merge 9 commits into
Conversation
ViniTou
left a comment
There was a problem hiding this comment.
Not going into details, but isnt this case covered by
ibexa/twig-components#25
?
b46c4ca to
2d7d50d
Compare
bnowak
left a comment
There was a problem hiding this comment.
looks good 💪 More likely, I'll reuse that part in async content publishing :)
don't forget to remove dependencies.json before merging 😉
| 'form' => $form, | ||
| 'version' => $version, | ||
| ]), | ||
| 110, |
There was a problem hiding this comment.
What is that value, priority/order? we could left some comment at least here 😉
as well as below
|
Hi! When talking with @Steveb-p about ibexa/twig-components#25 (ibexa/twig-components#25 (comment) , discussed on Quable daily ), the Table component was meant to be internal for now. Given this, do you still think it needs to be mentioned in the doc somehow? |
Hi! If there is some reasons that ibexa.Table component should be internal then IMO we should still not mention this component in the doc. |
9e02f66 to
a28d0d2
Compare
|
It is not intended for external use. At least not yet. Experimental at best. |
…_locationview domain
a28d0d2 to
1cc89e7
Compare



Revert
2d7d50dd0([CI] Added temporary dev dependency on ibexa/twig-components) before merge.Related PRs:
Description:
Rework of this PR after review feedback (thanks @ViniTou): instead of introducing a versions-specific column-provider mechanism, the Versions tab tables are migrated to the
ibexa.TableTwigComponent — the same extension point already used by product-catalog and connector-quable. Any package contributes a column with a plainPostMountEventsubscriber; no second mechanism, no new public contracts.VersionsTableSubscriberprovides the core columns (checkbox, version, modified language, contributor, created, last saved, actions) fromcontent/tab/versions/columns.html.twigblocks. Priorities 110–90 / 40–10; the 50–89 band is reserved for third-party columns.tab.html.twigand the draft-conflict modal. Forms, bulk-delete header tools, Pagerfanta pagination and theadmin-ui-versions-table-beforecomponent group are preserved.headlineprop), so subscribers may replace it (ibexa/workflow restores its "Drafts to review" headline this way).For QA:
On a content item with drafts, published and archived versions verify: bulk delete of drafts/archived (select-all, trash button enable, confirmation modal, POST to
ibexa.version.remove), drafts pagination (page param +#ibexa-tab-location-view-versionsfragment), draft-conflict modal table (no checkbox column, no "Created" column), per-row actions menu, archived restore. With ibexa/workflow enabled: "Workflow" column + "Drafts to review" headline on the drafts table for content in a workflow. With translations-management: "Translation status" column on drafts of auto-translated content.Documentation:
Template BC break —
content/tab/versions/table.html.twigis removed, together with its override blocks (custom_column_headers,custom_actions_column_headers,custom_columns,custom_actions_column) and thetable_template_pathvariable. Projects that overrode this template or those blocks must migrate to aPostMountEventsubscriber adding a column to theibexa.Tablecomponent (guard onTable::$type === 'versions'; seeVersionsTableSubscriberand the workflow/TM subscribers as references). Needs an upgrade note on doc.ibexa.co.