IBX-11780: Decoupled ContentOnTheFlyProcessor from ContentFormProcessor#1969
Draft
bnowak wants to merge 1 commit into
Draft
IBX-11780: Decoupled ContentOnTheFlyProcessor from ContentFormProcessor#1969bnowak wants to merge 1 commit into
bnowak wants to merge 1 commit into
Conversation
…or by publishing content synchronously via ContentService and added unit tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
ContentOnTheFlyProcessorno longer delegates to content-forms'ContentFormProcessorand no longer reads thecontentevent payload (removed from the publish flow by the ibexa/content-forms counterpart PR). It saves the draft and publishes synchronously viaContentServiceon its own — the same pattern asUserOnTheFlyProcessor— because the UDW handshake response must embed an existing location id, which a deferred (asynchronous) publication cannot provide. On-the-fly publishing therefore stays synchronous regardless of the asynchronous content publishing flag.Implementation note:
ContentOnTheFlyControllerroutes edit-on-the-fly publish throughCONTENT_CREATE_PUBLISH, soprocessCreatePublishhandles bothContentCreateDataandContentUpdateData;processEditPublishwas rewritten for consistency although it is unreachable via the current controller wiring. Unit tests for the processor were added.For QA:
Documentation:
No client-facing impact — internal refactoring; on-the-fly publishing remains synchronous.