IBX-12042: Deprecated filename-less download route in favor of filename-validated variant#775
Open
Conversation
wiewiurdp
force-pushed
the
IBX-12042-Deprecate-filename-less-download-route-content-download-contentId-fieldId-and-replace-it-with-a-filename-validated-variant
branch
from
July 6, 2026 15:17
e495713 to
5aa6a94
Compare
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
July 7, 2026 09:52
wiewiurdp
marked this pull request as ready for review
July 7, 2026 09:56
alongosz
reviewed
Jul 7, 2026
konradoboza
approved these changes
Jul 7, 2026
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
Apart from one comment and Andrew's remarks.
…in ContentDownloadUrlGenerator
bnowak
approved these changes
Jul 8, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
The
ibexa.content.download.field_idroute accepts plain integer parameters only, which allows enumerating and mass-downloading all accessible files with a simple loop overcontentId× fieldId (see IBX-11681, where filename validation was added to the main download route — this route bypassed it).Changes: