IBX-12003: Fix user OpenApi doc#231
Draft
adriendupuis wants to merge 11 commits into
Draft
Conversation
adriendupuis
marked this pull request as draft
June 29, 2026 15:16
adriendupuis
commented
Jun 29, 2026
| public function loadUserGroups(Request $request): RestValue | ||
| { | ||
| $restUserGroups = []; | ||
| if ($request->query->has('id') && is_int($id = $request->query->get('id'))) { |
Contributor
Author
There was a problem hiding this comment.
This couldn't work as $request->query->get('id')is always a string with an integer in it, not an integer.
adriendupuis
force-pushed
the
fix-user-openapi-doc
branch
from
July 9, 2026 08:53
1837339 to
567a220
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
The issue ticket IBX-12003 talk about
/user/usersbut I discovered that/user/groupshas the same issue, and the two are related.There was inconsistency in the
roleIdexpected values.Before:
$baseUri/user/users?roleId=2returns a "406 Not Acceptable" with "No route matched '2'".$baseUri/user/users?roleId=/api/ibexa/v2/user/roles/2returns a 404 on clean install, but if you assign role directly to a user, it would return 200 with this user. As this return only Users directly assigned, Group Users must be request as well…$baseUri/user/groups?roleId=/api/ibexa/v2/user/roles/2returns a 404 with "Could not find 'Persistence User Role' with identifier 'ID: 0, Status: 0'"$baseUri/user/groups?roleId=2returns a 200 with the Administrators groupAfter:
I modified so
roleId=2androleId=/api/ibexa/v2/user/roles/2are both accepted on the two resources.No backward compatibility break.
The same value can now be passed when using the two resources together to get all users having a role.
For QA:
Documentation: