Repository navigation
fix(proxy): preserve HTTP statuses for streaming errors - #841
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the actual HTTP error status when a streaming request fails before its SSE response body starts. Previously, the shared SSE error helper emitted an error event but left Hono's default HTTP 200 status, so clients and reverse proxies could treat failures as successful responses.
Changes
src/routes/shared/stream-error-response.ts; this covers direct upstream transport failures (502), proxy errors, and no-account responses (503).Test Plan
npx tsc --noEmit— passed on Windows.npm test— attempted on Windows: 3210 passed, 25 failed, 25 skipped across 13 failed files. Failures include POSIX shell/path incompatibilities (/bin/shunavailable andC:\...paths passed to bash), Electron hook timeouts, Windows EBUSY cleanup, and invalid-token errors in npm/release-notes tests. Full CI will run on GitHub.Notes
The Windows full-suite failures are not asserted to be caused by this patch; the changed streaming status tests pass in the focused run.