Add function that checks fermi sources within the real 90% contour #89
Open
azegarelli wants to merge 8 commits into
Open
Add function that checks fermi sources within the real 90% contour #89azegarelli wants to merge 8 commits into
azegarelli wants to merge 8 commits into
Conversation
ric-evans
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update with respect to the recent release, to check Fermi sources within the actual contour.
The user can choose, through the option check_fermi_sources_box, if checking from Fermi sources within the rectangular error box or the actual contour available from the map.
I've done some tests on these options installing in realtime containers the SkyReader version corresponding to this branch.
Example for the last alert (plot below)
Output setting
check_fermi_sources_box=TrueOutput setting
check_fermi_sources_box=FalseYou see that in the latter case FL16Y J2030.0+3641 doesn't appear anymore, as expected.