Use log10 in relevant SCM closures and update transient regime calculation - #33307
Use log10 in relevant SCM closures and update transient regime calculation#33307kyriv-lab wants to merge 16 commits into
Conversation
GiudGiud
changed the title
|
Job Documentation, step Docs: sync website on b6d5aa2 wanted to post the following: View the site here This comment will be updated on new commits. |
eb841c5 to
1d8193a
Compare
|
Job Precheck on 6ed7d6a : invalidated by @kyriv-lab |
|
Was this indexing issue behind the nonconverging results? |
No, that was just a small bug i found. It didn't have a big effect in the simulation results. |
|
Job Precheck, step Clang format on ccfef2c wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
you need to create an issue for this too and reference it in the commit |
924e79b to
171a67b
Compare
kyriv-lab
changed the title
Regold comparison against develCompared the current gold files on this branch against There are 19 gold CSV files different from
The largest changes are in the sodium-19pin/SFR cases. Those show a sizable mass-flow redistribution,
with The HTC correlation cases change by about 4-5 C, generally around 0.5-1.0%. Most validation temperature changes are smaller. The largest validation relative change outside the
sodium/SFR mass-flow redistribution is |
832136e to
b8f9f2a
Compare
2041713 to
1a7abb8
Compare
|
Job Coverage, step Generate coverage on b6d5aa2 wanted to post the following: Framework coverageCoverage did not change Modules coverageSubchannel
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
|
VTB patch: idaholab/virtual_test_bed#838 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a7abb8efe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Job Conda moose linux on 1a7abb8 : invalidated by @kyriv-lab |
a836907 to
71f74c2
Compare
53c5fe3 to
0053069
Compare
The old negative_htc_error case used wire_diameter=0.003 to try to force a non-physical Gnielinski HTC. After correcting the Cheng-Todreas logarithm to base 10, that geometry no longer reaches the HTC guard first; it instead drives the coupled solve into invalid mixing or negative enthalpy. The requested wire is also larger than the pin-to-pin gap for this benchmark geometry, so the input is invalid before any friction, mixing, or HTC closure should run. Add an early SCMTriAssemblyMeshGenerator validation that requires pitch to exceed pin diameter and requires dwire to be no larger than pitch - pin_diameter. Use MOOSE's fuzzy floating-point comparison so benchmark geometries where dwire equals the pin-to-pin gap are accepted. Rename the regression test to invalid_wire_diameter_error and make it expect this geometry error directly.
The sodium-19pin SFR tests used Gnielinski for the duct HTC closure while using Dittus-Boelter for the pins. With the HTC positivity guard active, the low-Pr sodium duct calculation can produce a non-physical Gnielinski HTC after the subchannel solve has converged, causing the explicit, implicit, and monolithic tests to exit with an error instead of reaching CSVDiff. Switch the duct HTC closure in all three sodium-19pin inputs to Dittus-Boelter, matching the existing pin HTC closure. The successful duct closure choices produce identical reported coolant/pin temperatures for these tests because duct_heat_flux is zero, so Dittus-Boelter is the simplest viable closure already present in the inputs. Regenerate the corresponding CSV gold files from passing direct runs.
The base-10 logarithm corrections change the wire-wrapped Cheng-Todreas friction/mixing response and the Borishanskii HTC result. The affected tests ran to completion but failed CSVDiff because their gold files still reflected the old natural-log behavior. Refresh the gold CSVs for the heat-transfer correlation cases, THORS blockage validation cases, ORNL-19, Toshiba-37, and the EBR-II SHRT-17 SFR problem using the outputs generated by the updated closures. This updates only baselines for tests whose numerical results changed because the intended closure formulas changed.
Store the assembly bulk Reynolds number on the subchannel problem and use it for the Updated Cheng-Todreas transition regime and interpolation parameter. Regold affected outputs.
…ngTodreas.md Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
0053069 to
b33791e
Compare
b33791e to
71d7932
Compare
d8c38c4 to
c2b986a
Compare
c2b986a to
6736937
Compare
|
@grmnptr please review. |
15ebb13 to
737a1c3
Compare
737a1c3 to
b6d5aa2
Compare
|
Job Test, step Results summary on b6d5aa2 wanted to post the following: Framework test summaryCompared against 7829c60 in job civet.inl.gov/job/4094367. No change Modules test summaryCompared against 7829c60 in job civet.inl.gov/job/4094367. Removed tests
Added tests
|
4 participants
This PR resolves issue #33306 and #33340