Skip to content

refactor: use the Buffer and BoundingBox types to perform the communication packing / unpacking in Axis & ConstrainedTransport classes#385

Merged
glesur merged 8 commits into
idefix-code:developfrom
svalat:refactor/mpi-exchanges-use-buffer-packer
Jul 8, 2026
Merged

refactor: use the Buffer and BoundingBox types to perform the communication packing / unpacking in Axis & ConstrainedTransport classes#385
glesur merged 8 commits into
idefix-code:developfrom
svalat:refactor/mpi-exchanges-use-buffer-packer

Conversation

@svalat

@svalat svalat commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

What

Replace the hand made buffer packing by using BoundingBox and Buffer into the Axis class in preparation to a larger refactoring to latter use the Exchanger class into Axis to manage the communications.

Process made in 3 steps

  1. Add the new communication way (duplicate)
  2. Compare both while running
  3. Removing old.

Needed a add UnpackJDirSymetric() in Buffer class.

Validation

  • 32 MPI process on MHD/AxisFluxTube in bound check + dual communication (new & old compared in flight by asserts)
  • Test suite on MHD/AxisFluxTube MPI.

Squash

I let the steps commits in the branch, but they can be squashed for the merge in develop.

@svalat svalat changed the title refactor: use the Buffer and BoundingBox types to perform the communication packing / unpacking in Axis class refactor: use the Buffer and BoundingBox types to perform the communication packing / unpacking in Axis & ConstrainedTransport classes Jul 6, 2026
@svalat svalat force-pushed the refactor/mpi-exchanges-use-buffer-packer branch from 1734561 to 986505b Compare July 6, 2026 11:38
@glesur glesur added the refactor refactorisation of internal code without affecting the results label Jul 8, 2026
@glesur glesur merged commit 39ff467 into idefix-code:develop Jul 8, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor refactorisation of internal code without affecting the results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants