Skip to content

do not show warning for balance issues on cpus #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glesur wants to merge 2 commits into
base: develop
Choose a base branch
from
+21 −16
Open

do not show warning for balance issues on cpus #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac820e0
do not show warning for balance issues on cpus
glesur Jul 7, 2026
86d6c29
compute balance on cpus, but show warning only on gpus
glesur Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions src/timeIntegrator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,24 +219,29 @@ double TimeIntegrator::ComputeBalance() {
}
computeMean /= idfx::psize;
imbalance = (computeMax-computeMin)/computeMean*100;

if(imbalance>allowedImbalance ) {
idfx::cout << "-------------------------------------------------------------"<< std::endl;
idfx::cout << "Warning: MPI imbalance found in this run " << std::endl;
idfx::cout << std::fixed;
for(int i = 0 ; i < idfx::psize ; i++) {
if(computeLogPerCore[i]/computeMean - 1> allowedImbalance/2/100) {
idfx::cout << "+" << 100*(computeLogPerCore[i]/computeMean-1)
<< "% (proc " << i << ")" << std::endl;
}
if(1-computeLogPerCore[i]/computeMean > allowedImbalance/2/100) {
idfx::cout << "-" << 100*(1-computeLogPerCore[i]/computeMean)
<< "% (proc " << i << ")" << std::endl;
// only show warnings if the imbalance is higher than 20%on GPUs
#if defined(KOKKOS_ENABLE_CUDA) || defined(KOKKOS_ENABLE_HIP) || defined(KOKKOS_ENABLE_SYCL)
if(imbalance>allowedImbalance ) {
idfx::cout << "-------------------------------------------------------------"
<< std::endl;
idfx::cout << "Warning: MPI imbalance found in this run " << std::endl;
idfx::cout << std::fixed;
for(int i = 0 ; i < idfx::psize ; i++) {
if(computeLogPerCore[i]/computeMean - 1> allowedImbalance/2/100) {
idfx::cout << "+" << 100*(computeLogPerCore[i]/computeMean-1)
<< "% (proc " << i << ")" << std::endl;
}
if(1-computeLogPerCore[i]/computeMean > allowedImbalance/2/100) {
idfx::cout << "-" << 100*(1-computeLogPerCore[i]/computeMean)
<< "% (proc " << i << ")" << std::endl;
}
}
idfx::cout << "You should probably check these nodes are running properly."
<< std::endl;
idfx::cout << "-------------------------------------------------------------"
<< std::endl;
}
idfx::cout << "You should probably check these nodes are running properly." << std::endl;
idfx::cout << "-------------------------------------------------------------"<< std::endl;
}
#endif
}
#endif
return(imbalance);
Expand Down
Loading