New control signal - #34
Merged
Merged
Conversation
mich-pest
force-pushed
the
new_control_signal
branch
from
August 11, 2026 14:46
9304c29 to
f082023
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the new policy for controller-related message publication.
What changed?
Before a generic controller had to send
ControlSignalmessage (encoding the torques) to theControlLayer- that was responsible for sendingDesiredTorquesmessages to the robot HAL - AND to send directly TrajectoryGenerator messages (encoding desired position and velocity, kp, kd) to HAL on different topics.In the new structure
ControlSignalhas been modified as follows:With
control_modespanning the following supported modes:The generic controller publishes directly a

ControlSignalmessage to theControlLayer. Then theControlLayeris responsible to publish aControlSignalmessage read by the HAL.More details in iit-DLSLab/dls2#334