Repository navigation
excore check: report rule coverage and warn about rules with no effect - #5
Merged
Merged
Conversation
ikeige-coder
approved these changes
Oct 5, 2026
ikeige-coder
approved these changes
Oct 5, 2026
Owner
There was a problem hiding this comment.
Merging. This catches rules that silently own no units after later rules override them, which is an easy mistake when tuning recipes. It's a warning only, exit code unchanged, and the tests cover the counts and the CLI output.
Follow-up nit, not blocking: a rule can also own zero units because its match hits nothing (a typo). The warning currently says "later rules override every unit it matches". A reword would actually do, But nevermind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules are applied in order, so a later rule can silently override everything an earlier one matched. The earlier rule then looks active in the manifest but changes nothing, which is an easy mistake to make when tuning recipes.
excore check now prints how many units stay on the default and warns (stderr, exit code unchanged) for every rule that ends up owning no units. ScreenReport gains rule_units, default_units and unused_rules. Tests cover the counts and the CLI warning.