Repository navigation
Validate manifest input strictly and report unreadable manifest files cleanly - #6
Merged
ikeige-coder merged 1 commit intoOct 5, 2026
Conversation
ikeige-coder
approved these changes
Oct 5, 2026
ikeige-coder
left a comment
Owner
There was a problem hiding this comment.
Approved. re.match with a $ anchor accepts a trailing newline, so a manifest name like "evil\n" passed validation. Manifest names and patterns come from untrusted miner PRs, so fullmatch is the right fix. Clean errors for unreadable or non-UTF-8 manifests are also a good catch, and the tests cover both. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the manifest path, which treats files as untrusted input.
Tests cover each case.