Repository navigation
Conversation
A dba_popen() handle outlives the request, but flatfile kept the buffer of the last returned key, inifile its current and last-fetched lines, and cdb_make its hash list in it as emalloc'd memory, which the next request or the close at shutdown then freed or read. flatfile now frees the key right away and uses its file position as the iteration marker; inifile and cdb_make allocate what they keep with the persistence of the handle.
iliaal
force-pushed
the
fix/aph-dba-flatfile-request-allocation-7x8y-84-work
branch
from
November 2, 2026 14:01
378c34e to
d148af8
Compare
Owner
Author
|
Promoted upstream: php#25155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match flatfile iterator buffer allocation and release to persistent connection lifetime so retained keys survive request boundaries safely.