Repository navigation
Harden CI workflows and group vitest updates - #473
Merged
Merged
Conversation
- timeout-minutes on every job in pr-check, publish, codeql and pi-canary. - pr-check: npm audit signatures after install; a zizmor job (pinned setup-uv, zizmor 1.32.0, .github/zizmor.yml requiring SHA pins); a final CI job that needs every other job and fails unless each one succeeded. - publish: fixed concurrency group with cancel-in-progress false, and package-manager-cache: false on every setup-node so no cache is restored in a release run (zizmor cache-poisoning). - pi-canary: the npm install of @latest pi packages carries an inline zizmor ignore for adhoc-packages, since installing the newest release is the purpose of that job.
Dependabot gets a vitest group (vitest, @vitest/*) after the pi group, so vitest and its plugins move together. biome.json's $schema now names the installed Biome version.
The inline "# zizmor: ignore" sat inside the run command, so the shell treated the --no-save, --ignore-scripts and @latest arguments as a comment and ran a bare npm install. The ignore is now its own YAML comment line and the command is unchanged from before the hardening commit.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Brings the workflows to a common CI baseline.
timeout-minuteson every job in pr-check, publish, codeql and pi-canary (15; 5 for the aggregate job).npm audit signaturesafternpm ciin the check matrix; aWorkflow audit (zizmor)job runningzizmor@1.32.0with.github/zizmor.yml(every action must be SHA-pinned); a finalCIjob that needs every other job, runsif: always(), and fails unless every result issuccess(no job in the workflow is conditional, soskippedcounts as a failure). Existing job names and matrix entries are unchanged.concurrencygrouppublishwithcancel-in-progress: false;package-manager-cache: falseon every setup-node, removing the npm cache from the check job, so no cache is restored in a release run.zizmor: ignore[adhoc-packages]on thenpm install ...@lateststep, which exists to test unlocked pi releases.vitestgroup (vitest,@vitest/*) betweenpiandminor-and-patch.$schemapoints at 2.6.8, the installed version.zizmor 1.32.0 on
.github/workflowsreported 3 cache-poisoning errors in publish.yaml and 1 adhoc-packages note in pi-canary.yaml before this change, and no findings after it.npm run checkpasses (Biome, strict tsc, Vitest)