Skip to content

Harden CI workflows and group vitest updates - #473

Merged
ilovepixelart merged 3 commits into
mainfrom
ci/baseline-hardening
Nov 17, 2026
Merged

ilovepixelart merged 3 commits into
mainfrom
ci/baseline-hardening

Conversation

@ilovepixelart

Copy link
Copy Markdown
Owner

Brings the workflows to a common CI baseline.

  • timeout-minutes on every job in pr-check, publish, codeql and pi-canary (15; 5 for the aggregate job).
  • pr-check: npm audit signatures after npm ci in the check matrix; a Workflow audit (zizmor) job running zizmor@1.32.0 with .github/zizmor.yml (every action must be SHA-pinned); a final CI job that needs every other job, runs if: always(), and fails unless every result is success (no job in the workflow is conditional, so skipped counts as a failure). Existing job names and matrix entries are unchanged.
  • publish: fixed concurrency group publish with cancel-in-progress: false; package-manager-cache: false on every setup-node, removing the npm cache from the check job, so no cache is restored in a release run.
  • pi-canary: inline zizmor: ignore[adhoc-packages] on the npm install ...@latest step, which exists to test unlocked pi releases.
  • dependabot: vitest group (vitest, @vitest/*) between pi and minor-and-patch.
  • biome.json $schema points at 2.6.8, the installed version.

zizmor 1.32.0 on .github/workflows reported 3 cache-poisoning errors in publish.yaml and 1 adhoc-packages note in pi-canary.yaml before this change, and no findings after it.

  • npm run check passes (Biome, strict tsc, Vitest)
  • Tests cover the change (CI configuration only; exercised by this PR's own run)

- timeout-minutes on every job in pr-check, publish, codeql and pi-canary.
- pr-check: npm audit signatures after install; a zizmor job (pinned
  setup-uv, zizmor 1.32.0, .github/zizmor.yml requiring SHA pins); a final
  CI job that needs every other job and fails unless each one succeeded.
- publish: fixed concurrency group with cancel-in-progress false, and
  package-manager-cache: false on every setup-node so no cache is restored
  in a release run (zizmor cache-poisoning).
- pi-canary: the npm install of @latest pi packages carries an inline
  zizmor ignore for adhoc-packages, since installing the newest release is
  the purpose of that job.
Dependabot gets a vitest group (vitest, @vitest/*) after the pi group, so
vitest and its plugins move together. biome.json's $schema now names the
installed Biome version.
The inline "# zizmor: ignore" sat inside the run command, so the shell
treated the --no-save, --ignore-scripts and @latest arguments as a comment
and ran a bare npm install. The ignore is now its own YAML comment line and
the command is unchanged from before the hardening commit.
@sonarqubecloud

Copy link
Copy Markdown

@ilovepixelart
ilovepixelart merged commit 29441cb into main Nov 17, 2026
22 of 24 checks passed
@ilovepixelart
ilovepixelart deleted the ci/baseline-hardening branch November 17, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant