chore: remove examples, consolidate sample apps#2917
Open
alex-connolly wants to merge 2 commits into
Open
Conversation
Delete the unused examples/ tree (orphaned after the Mintlify docs migration) and trim sample apps: drop dex/bridge samples, merge the checkout playgrounds into one sample-app, and rename remaining apps to sample-app. Co-authored-by: Cursor <cursoragent@cursor.com>
|
| Metric | Size | Delta vs main (f8ac366) |
|---|---|---|
| Gzipped | 21683 bytes (21.17 KB) | 0 bytes |
| Raw (minified) | 63197 bytes | 0 bytes |
Budget: 24.00 KB gzipped (warn at 20.00 KB)
⚠️ Approaching budget — gzipped size exceeds 20.00 KB warning threshold.
|
View your CI Pipeline Execution ↗ for commit 262bb6b
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Move passport.connectEvm() into useEffect so Vite production builds do not fail on environments that lack top-level await. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/tree — no longer consumed by Mintlify docs (only linked from the old Docusaurus site), and CI example build/test job removed with itdexandbridgesample apps (internal packages already exercised via Checkout)packages/checkout/sample-app(SDK methods under/sdk)sample-app(@imtbl/{passport,checkout,audience}-sample-app)packages/x-providerpath / CODEOWNERS entry (package already removed from main)Test plan
build-lint-test-examplesjob)pnpm installsucceeds with updated workspacepnpm --filter @imtbl/passport-sample-app exec echo ok(and checkout/audience equivalents)pnpm --filter @imtbl/checkout-sample-app start— home lists widgets +/sdkroutes@imtbl/passport-sample-app(S3 prefix unchanged)Made with Cursor