Update SSH Compression recommendation to reflect modern OpenSSH behavior - #137
Open
harshvasudeva wants to merge 1 commit into
Open
Conversation
OpenSSH moved to delayed (post-authentication) compression by default in 6.7, and removed pre-authentication compression support entirely in 7.4 (2016). The compression-oracle attack surface that motivated the original `Compression no` recommendation no longer exists on any currently supported OpenSSH version, so `Compression yes` is safe. Fixes imthenachoman#117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compressionrecommendation insshd_configfromnotoyes, with a comment explaining why.Compression norecommendation no longer exists on any currently supported OpenSSH version.Fixes #117
References