Repository navigation
refactor: import BLE binding contract types from incyclist-services - #474
Merged
Merged
Conversation
BleInterfaceState, BleProperty, BleCharacteristic, BleRawCharacteristic, BleService and DiscoverResult were hand-copied from incyclist-devices and drifted silently when devices widened BleProperty. Import them (type-only) from incyclist-services instead. BleBinding, BleRawPeripheral, BleAdvertisement and BleServiceData stay local on purpose, with a comment saying why. Needs an incyclist-services release that re-exports these types.
|
gdoumen
marked this pull request as ready for review
October 14, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/bindings/ble/types.tshand-copied the BLE binding contract fromincyclist-devices, so a change there (the widenedBleProperty) was invisible here until CI broke. The types that have an exact upstream equivalent are now imported (type-only) fromincyclist-services.What changed
incyclist-services:BleInterfaceState,BleProperty,BleCharacteristic,BleRawCharacteristic,BleService,DiscoverResult(exact shape parity checked against devices).BleBinding(devices' version also requires a_bindingsmember this binding does not have),BleRawPeripheral(identical exceptadvertisementis typed here,anyupstream),BleAdvertisementandBleServiceData(no upstream equivalent; devices only has a differentBleRawAdvertisement).Notes
Depends on incyclist/services#643 being merged and released; until
incyclist-servicesis bumped here the type-check will fail on the missing exports.Test plan
src/bindings/bletests and the full jest suite passtscpasses against a local build of the services branchincyclist-services