Repository navigation
feat: add video audio controls to ride settings - #476
Merged
Merged
Conversation
Integrate video audio preferences into the mobile ride settings:
- Accept isRide prop in RideSettings to distinguish ride vs app settings contexts
- Add onChangeVideoAudio callback to handle audio preference changes
- Display video sound toggle in RideSettingsView using BinarySelect
- Extend RideSettingsViewProps from RideSettingsDisplayProps for cleaner prop handling
- Update RideMenuView to pass isRide={true} when opening ride settings
- Bump incyclist-services to 1.9.7 for video settings support
- Update Storybook to 10.6.2
|
gdoumen
marked this pull request as ready for review
October 14, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrate video audio preferences into the mobile ride settings dialog, allowing users to toggle video sound during active rides.
Changes
isRideprop in RideSettings to distinguish between ride context and app settings contextsonChangeVideoAudiocallback to handle audio preference changesisRide={true}from RideMenuView when opening ride settingsDependencies
Requires:
Test Plan
npm test