Repository navigation
feat: align Activity page with Routes design (INC-47) - #60
Open
joaopavila wants to merge 2 commits into
Open
joaopavila wants to merge 2 commits into
joaopavila wants to merge 2 commits into
Conversation
Contributor
My ReviewThis looks really nice. I love it !! Two things I observed:
AI ReviewVerdict: nearly ready. The PR covers everything in the ticket and closely follows the Routes list pattern. Before merge I'd ask for two fixes: restore interaction logging, and split the card into smart and view halves. CI passes on Node 24 and 25, and the branch merges cleanly into main (it's 2 commits behind: a version bump and a services bump). Against the ticket
The scrolling rewrite now uses the shared Should fix
Worth fixing
Nits
|
gdoumen
requested changes
Oct 28, 2026
| const { summary, details: suppliedDetails } = activityInfo ?? {} | ||
| const id = summary?.id | ||
| const [loaded, setLoaded] = useState(null) | ||
| const details = loaded?.id === id ? { ...suppliedDetails, ...loaded.details } : suppliedDetails |
Contributor
There was a problem hiding this comment.
This crashes if loaded is null (default)
replace with loaded?.details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Activities page now uses the Routes page’s design language while retaining a list-only layout. Each activity card shows the service summary title, date and time, duration, power profile, distance, and total ascent; upload-status pills use the existing
summary.uploadStatusdata.Preserves activity details and deletion, adds keyboard activation, and reuses the shared fold-window hook for scrolling and lazy rendering. Filters, view toggles, and service changes remain outside this PR.
Screenshot
Storybook preview using sample activity data, captured at 1440 × 900.
Validation
CI=true npm test: 571 tests across 64 files.isFreeRideSupported, fixing the pre-existing Free Ride test failure.npm run buildpassed.