Add ContestRequest model for Contest Creator rights request workflow#1
Open
GauriGupta21 wants to merge 1 commit into
Open
Add ContestRequest model for Contest Creator rights request workflow#1GauriGupta21 wants to merge 1 commit into
GauriGupta21 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A new
ContestRequestmodel representing a user's request for Contest Creator rights — this is a permission request, not a contest itself.Why this design
Initially I migrated the old
wikicontestbackend'sContestRequestmodel, which duplicated almost allContestfields (name, dates, scoring, categories, jury members, etc.) via a shared mixin.After confirming the actual product workflow with the team, we agreed this was unnecessary:
ContestRequestminimal avoids duplicatingContest's schema and keeps the two concerns (permission vs. contest) properly decoupled.Fields
iduser_id(FK → users.id — requester)reason(required)edit_count(cached Wikimedia edit count at request time)status(pending / approved / rejected, default 'pending')reviewed_by(FK → users.id — superadmin who reviewed)reviewed_atrejection_reasoncreated_atHow I tested this
flask db upgrade) against SQLiteflask shell:Confirms: record saves, default
status='pending'applies automatically, all fields retrieve correctly.