Repository navigation
Bump Jenkins Go tool to 1.26.8 - #67
Merged
Merged
Conversation
Matches the Docker builder and the CI workflows, both of which are on 1.26.8. The previous value, 1.25.5, could not build this module at all since go.mod requires go 1.26.0. This does not change pipeline behaviour today: nothing in the repo uses the provisioned toolchain. `make build` shells out to `docker build`, so compilation happens inside golang:1.26.8-alpine3.24; `make test` is commented out; and `make list-of-images` and `make clean` are an echo and an rm. The tools block, GOPATH and checkoutToSubdirectory are left over from when the pipeline ran go directly. Note the value is a Jenkins tool-installation name, not a version string, so "Go 1.26.8" has to exist in the Jenkins global tool configuration or the pipeline fails at startup.
Coverage Report for CI Build 35299659971Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 52.649%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools { - go "Go 1.25.5" + go "Go 1.26.8" }Brings the Jenkins toolchain in line with the Docker builder and the GitHub Actions workflows, both already on 1.26.8. The previous value could not build this module at all —
go.modrequiresgo 1.26.0, so 1.25.5 would be rejected outright.This changes no pipeline behaviour today
Verified that nothing in the repo uses the provisioned toolchain:
make builddocker buildonly — compilation happens insidegolang:1.26.8-alpine3.24make testJenkinsfile:30)make list-of-images@echomake cleanrm -r ./cli/buildThe
toolsblock, along withGOPATH = "$WORKSPACE"andcheckoutToSubdirectory, is left over from when this pipeline ran Go directly rather than delegating to a Docker build. So this is a consistency fix that also stops the declaration being actively wrong — it would start mattering the moment someone uncommentsmake test.Not verified:
prepareBuild()andfinalizeBuild()come from@Library('jenkins.shared.library'), which isn't in this repo. If those shell out togo, they'd use the provisioned toolchain — and they'd currently be getting a version that can't build this module.Required Jenkins-side change
This value is a tool-installation name, not a version string.
"Go 1.26.8"must exist in Jenkins' global tool configuration or the pipeline fails at startup withNo tool named Go 1.26.8 found. Repo history shows exact-patch names throughout (Go 1.14.4,1.17,1.20,1.22.4,1.24.2,1.25.5), so each bump has been paired with a Jenkins config entry. Please confirm that entry exists before relying on this.No GitHub Actions workflow reads
Jenkinsfile, so CI here cannot exercise the change either way.🤖 Generated with Claude Code