Repository navigation
[IMP] purchase_ux: clarify the "Not Acknowledged" purchase dashboard card - #382
Closed
fw-bot-adhoc wants to merge 1 commit into
Closed
fw-bot-adhoc wants to merge 1 commit into
fw-bot-adhoc wants to merge 1 commit into
Conversation
…card In es_419 the core card is translated as "Sin recibir" while its own tooltip reads "no reconocidas". The counter also drops when a receipt is validated, because purchase_stock calls action_acknowledge() from picking._action_done(), so users read the card as pending deliveries. Rename the card, its two tooltips and the search filter to state what the counter really holds: purchase orders with no vendor acknowledgement and no validated receipt. The "Acknowledge" button is renamed as well, since es_419 translates it as "Confirmar", the same word used for "Confirm Order". Labels only, no behaviour change. Change note: se renombra la tarjeta "Sin recibir" del tablero de Compras, sus globos de ayuda y el filtro de búsqueda, que cuentan órdenes de compra sin acuse del proveedor y sin recepción validada. X-original-commit: f5d78e1
Contributor
Author
|
@jcadhoc @les-adhoc cherrypicking of pull request #380 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
Superseded by #389, which brings this commit to 20.0 and adapts the dashboard card to the 20.0 template ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ticket: https://www.adhoc.inc/odoo/helpdesk.ticket/128398
Qué duele
El cliente ve en el tablero de Compras una tarjeta rotulada "Sin recibir" y la lee como mercadería pendiente de llegar. No es eso: cuenta órdenes de compra sin acuse de recibo. Son dos problemas sumados.
La traducción es_419 del core es inconsistente. El mismo concepto aparece con cuatro palabras distintas:
El globo de ayuda de esa misma tarjeta sí dice "no reconocidas", y el campo del formulario dice "Reconocido". El castellano de España está bien; el problema es solo es_419, que
get_base_langsaplica a cualquier español latino.El contador no mide solo el acuse del proveedor.
purchase_stockllama aaction_acknowledge()desdestock.picking._action_done(), así que validar una recepción marca el mismo booleano que el clic del proveedor en el portal. La tarjeta baja también ahí, lo que refuerza la lectura equivocada.Qué cambia
Solo textos, ningún cambio de comportamiento. Los rótulos pasan a decir lo que el contador realmente tiene — órdenes sin acuse del proveedor y sin recepción validada:
action_acknowledgedel formulario, que en es_419 se llamaba "Confirmar" igual que "Confirmar orden".La tarjeta se corrige por plantilla y no por traducción porque es un término de código:
get_po_paths()busca el catálogo del módulo dueño (purchase), así que un.poenpurchase_uxnunca la alcanza.Cómo sabemos que está
pre-commit run --filessobre los cinco archivos: todo en verde.Preguntas abiertas
es.poy en el.potpara que el cliente lo vea en español sin esperar una ronda de traducción; si eso choca con el flujo de Weblate, decímelo y las saco.acknowledged("Reconocido") y suhelp, que también dice que el proveedor acusó recibo cuando puede haberlo marcado la recepción. Es del core.Forward-Port-Of: #380