Repository navigation
[FIX] purchase_stock_ux: use product_uom_id when merging procurement into PO line - #394
Closed
pablohmontenegro wants to merge 1 commit into
Closed
pablohmontenegro wants to merge 1 commit into
pablohmontenegro wants to merge 1 commit into
Conversation
Contributor
|
|
pablohmontenegro
changed the title
Contributor
|
@roboadhoc r+ nobump |
pablohmontenegro
force-pushed
the
19.0-h-131058-pam
branch
2 times, most recently
from
October 28, 2026 14:56
e8aa2c1 to
f698592
Compare
Contributor
Author
|
Hola @ingadhoc/devops ¿cómo están?, no estamos logrando mezclar este pull request, no se por qué no se generó la build de runbot. |
|
@pablohmontenegro el pr hermano esta en wip https://github.com/ingadhoc/odoo-saas-adhoc/pull/3506 por eso este no se disṕaro, lo dispare manual pero dio error |
…into PO line In 19.0 purchase.order.line.product_uom was renamed to product_uom_id. The standard price fallback in _update_purchase_order_line still used the old name, so merging a buy procurement into an existing RFQ line raised AttributeError when the vendor had no price and the product had a cost.
pablohmontenegro
force-pushed
the
19.0-h-131058-pam
branch
from
October 29, 2026 11:50
f698592 to
6ea0ccc
Compare
Contributor
|
@roboadhoc r+ |
roboadhoc
pushed a commit
that referenced
this pull request
Oct 29, 2026
…into PO line In 19.0 purchase.order.line.product_uom was renamed to product_uom_id. The standard price fallback in _update_purchase_order_line still used the old name, so merging a buy procurement into an existing RFQ line raised AttributeError when the vendor had no price and the product had a cost. closes #394 Signed-off-by: Luciano Esperlazza <les@adhoc.inc>
Contributor
|
@roboadhoc check |
Contributor
|
Updated message. No update to pr head. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://www.adhoc.inc/odoo/helpdesk.ticket/131058
In 19.0
purchase.order.line.product_uomwas renamed toproduct_uom_id. The standard price fallback instock.rule._update_purchase_order_linestill used the old name.Reproduction
AttributeError: 'purchase.order.line' object has no attribute 'product_uom'.Fix
Use
product_uom_id. Added a test that runs two buy procurements and checks that they merge into one line priced at the product cost.