Repository navigation
fix(nomad): keep the counts a job runs with on an edit, unless the file changes them - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
An edit of a job no longer resets the counts it runs with (#104). urga registered the edited file with the counts written in it, so a group the autoscaler, or
son task groups, had scaled to 5 went back to the file'scount = 1the next time anything in the job was edited. The plan showed it in its diff, next to the change you made, and it was easy to miss.countyou left as it was in the file keeps the count it runs with. Acountyou change in the editor is used as written. A group the job does not run yet gets the count of the file.Task group "web": 5, the file says 1.PreserveCountsis not used: it ignores every count of the file for a group that exists, so a count changed in the editor would be lost.file(), the editor still opens, and the plan says every count is the one in the file.Closes #104
Checklist
make checkis greenfeat(ui): ...,fix(nomad): ...