Repository navigation
fix(ui): close a feed that no page takes, and finish the audit refactors - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The rest of the code quality audit of 2026-10-16: one bug and two refactors.
:eventsdid not take is closed now. The messages that bring an opened stream share one method,release(), and the route that closes streams no page took matches that interface, not a list of types. The old list had three of the four kinds, so a second feed opened next to the one:eventsreads stayed open.:find,:gc,:run) come from one table: their names, whether they change the cluster, and what they run. Read-only mode is checked once, for every verb that writes, and a test goes over the table, so a new verb is covered too. A user sees one change::gcin read-only mode now saysread-only: :gc is off, the way a key and:runsay it.config.Loadtakes the path of its file, assettings.Loaddoes, andmainpasses it.Config.Save, which only tests called, is gone; the tests write throughSnapshotandWrite, the way the UI does, and no longer setXDG_CONFIG_HOMEfor it. A new test incmd/urgachecks that urga reads the session fromurga/config.jsonin the config folder, since the file name now lives inmain.Closes #117
Closes #123
Closes #124
Checklist
make checkis greenfeat(ui): ...,fix(nomad): ...