Repository navigation
feat(ui): watch volumes, plugins and variables with the event stream, and show the events of one job or allocation - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Volumes, CSI plugins and variables now update as soon as they change, the way
jobs and allocations do, and
oon a job or an allocation opens:eventsforthat one object only.
:volumes, a volume,:pluginsfollow the event stream on Nomad 1.10 andlater;
:variablesand a variable on Nomad 2.0 and later. A cluster does notrefuse a topic it does not know when ACLs are off, it just never sends
anything, so urga checks the version of the cluster first. On an older
cluster, or when it cannot read the version, these screens are read every 2
seconds, as before.
:eventsnames the volume, plugin or variable an event is about, andenteropens it.oon the job list opens the events of the job, its allocations,evaluations and deployments; on any list of allocations and on the tasks
screen, the events of the allocation. The cluster filters them by key, so
only those arrive, and a token that can read the job is enough. The screen
stays on its job or allocation when you switch namespace. Not shown for a
periodic or parameterized job.
Left for later: urga reads the version of the cluster from the agent's member
tags, which are empty when it talks to a client agent; there these screens
stay polled.
Closes #110
Closes #109
Checklist
make checkis greenfeat(ui): ...,fix(nomad): ...