Repository navigation
feat(ui): move a text sideways, save it to a path you type, and read a log further back - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Three things for reading and keeping long texts: logs, files, descriptions and
plans.
left/handright/lmove a text sideways by a quarterof the window, up to where the end of the widest line meets the right edge.
Logs and files say how far on the toggles line (
Column:41), other textscreens in the title.
homegoes back to the start of the lines first, thento the top;
galways goes to the top. Wrap on puts the text back at thestart. Find and filter matches move with the text. On a plan, left and right
still choose a button.
ctrl+sasks for the path on the line at the top, with the name it used tosave under already typed, so
enterkeeps it.~/is the home folder, arelative path is from where urga runs, missing folders are made, and an
existing file is overwritten only after a question. The status line says
where it was saved.
eon the log of a task reads the 1 MiB before what is shown, across therotated files that are still there, and puts it above the lines already on
the screen without moving the window. The title then says how much of the
log is read, as a file's does. The line limit of Followed logs grow without a limit and slow the UI down #63 still holds. It needs a
token that can read the files of the allocation; without it the status line
shows the refusal.
Found and fixed along the way: a tab in a description is drawn as four spaces,
so a line with a tab now moves sideways by the same cells it is drawn in.
Nomad writes log paths with backslashes on a Windows client; reading further
back takes that into account.
A test that ends while it leaves the session write running failed on the
Windows runner, where that write is slow: the write landed in the test's
folder while it was being removed. The tests that load a session config now
write it once more when they end, which waits for a write still running and
leaves nothing for a later one to write (its own commit,
chore(ui)).Left for later (in the ideas list):
fandndo not move the text sidewaysto a match past the right edge; after the stream drops lines off the front,
the title keeps the size read by the last
e.Closes #107
Closes #108
Closes #106
Checklist
make checkis greenfeat(ui): ...,fix(nomad): ...