Only include files with open editors in Analyze All Open Files - #115
Open
Bazooper-blip wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
GetOpenSourceModulesiterated all ofIOTAModuleServices.Modulesand filtered only by the.pasextension. That collection also contains modules that no longer have an open editor — for example files that were recently closed but whose module hasn't been released yet — which is why "Analyze All Open Files" sometimes analyzed more files than were open.The function now additionally requires the module to have a source editor with at least one edit view, the usual ToolsAPI test for "actually open in the editor".
Testing: new unit test covering the two exclusion cases (module without a source editor, source editor without edit views); the existing
GetOpenSourceModulestest was updated so its mock modules have open editors.