Fix OVMS reasoning parser resolution for OpenVINO models (#556) - #573
Open
Ultron09 wants to merge 1 commit into
Open
Fix OVMS reasoning parser resolution for OpenVINO models (#556)#573Ultron09 wants to merge 1 commit into
Ultron09 wants to merge 1 commit into
Conversation
Resolve OpenVINO Model Server (OVMS) --reasoning_parser dynamically based on model capabilities and reasoningParser override from models.json instead of hardcoding to qwen3. Also restore missing ttsVoiceSeed module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #556.
When launching OpenVINO Model Server (OVMS) for LLM text generation in
openVINOBackendService.ts, the--reasoning_parserCLI flag was previously hardcoded to'qwen3'.This caused inference for Harmony-format models like
OpenVINO/gpt-oss-20b-int4-ovto fail / leak the rawanalysisreasoning channel directly intocontent, because OVMS expects--reasoning_parser gptossto separate reasoning intoreasoning_content.Changes Made
Schema & Model Definitions:
ovmsReasoningParsers = ['qwen3', 'gptoss', 'lfm2', 'gemma4'] as constandreasoningParser: z.enum(ovmsReasoningParsers).optional()toModelSchemainWebUI/src/types/shared.ts.reasoningParser?: stringtoModeltype inWebUI/src/assets/js/store/models.ts."reasoningParser": "gptoss"forOpenVINO/gpt-oss-20b-int4-ovinWebUI/external/models.json.OpenVINO Subprocess & Argument Resolution:
resolveOvmsToolParserandresolveOvmsReasoningParserhelpers.startOvmsLlmServerto pass--reasoning_parser <parser>dynamically: uses model-specific override (e.g.gptoss), defaults to'qwen3'for models supporting reasoning, and omits the flag when reasoning is disabled.Typecheck & Voice Seed Utility:
WebUI/src/lib/ttsVoiceSeed.tsimplementingrandomVoiceSeed,stableVoiceSeed, andseedForVoicefor reproducible voice design sampling.Automated Unit Tests:
WebUI/electron/test/subprocesses/openVinoParsers.test.tscovering tool and reasoning parser resolution.WebUI/src/lib/ttsVoiceSeed.test.tscovering voice seed determinism and random bounds.Verification
npm testpassed (all 27 test files, 212 tests passing).npx vue-tsc --noEmitpassed with 0 errors.npm run lint:ciandnpm run format:cipassed.npm run lint:python(ruff + bandit) passed.