va: include <unistd.h> for getuid/getgid in secure_getenv fallback#889
Open
XinfengZhang wants to merge 1 commit into
Open
va: include <unistd.h> for getuid/getgid in secure_getenv fallback#889XinfengZhang wants to merge 1 commit into
XinfengZhang wants to merge 1 commit into
Conversation
On platforms like NetBSD (and other non-glibc systems), getuid(), geteuid(), getgid(), and getegid() are not implicitly available. They require an explicit include of <unistd.h> per POSIX. Without it the build fails with undefined function errors. Fixes: intel#888 Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888
On platforms like NetBSD (and other non-glibc systems),
getuid(),geteuid(),getgid(), andgetegid()are not implicitly available —they require an explicit
#include <unistd.h>per POSIX. Without it,the build fails with undefined function errors in the
secure_getenvfallback in
va/va_internal.h.The fix adds the missing include inside the
#elsebranch that isonly compiled on non-Windows platforms where
HAVE_SECURE_GETENVisnot defined.